Not all date nodes are shown without grouping [#376389]

I have following problem with date and week calendar views (using the dev releases of date and calendar from 2009-Feb-18 and views 6.x-2.3):

When I st time grouping in a date view to "Hour" I see all date nodes of a day (see attached screenshot "day_view_with_hour_grouping.jpg"). But when I set time grouping to "None", I see not all date nodes any more (see attached screenshot "day_view_without_grouping.jpg"). The same happens in week views.

Comment	File	Size	Author
	day_view_without_grouping.jpg	31.25 KB	brahms
	day_view_with_hour_grouping.jpg	59.72 KB	brahms

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

NickSI CreditAttribution: NickSI commented 19 February 2009 at 15:16

The bug seems to be in theme.inc

    // If we're not grouping by time, move all items into the 'all day' array.
    if (empty($view->date_info->style_groupby_times)) {
      foreach ($row['data']['items'] as $item) {
        $row['data']['all_day'] += $item;
      }
      $row['data']['items'] = array();
    }

$item variable in foreach statement is an array or node (all events for an hour), not just node. So it is nessesary to add an extra foreach loop as in code below.

    // If we're not grouping by time, move all items into the 'all day' array.
    if (empty($view->date_info->style_groupby_times)) {
      foreach ($row['data']['items'] as $hour) {
        foreach ($hour as $item) {
          $row['data']['all_day'][] = $item;
        }
      }
      $row['data']['items'] = array();
    }