Just updated to Beta 1 and received this sql error
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'INT) FROM drupal_profile_fields pf INNER JOIN drupal_profile_values pv ON pf' at line 2 query: INSERT INTO drupal_user_stats_values (name, uid, value) SELECT 'login_count', pv.uid, CAST(pv.value AS INT) FROM drupal_profile_fields pf INNER JOIN drupal_profile_values pv ON pf.fid = pv.fid WHERE pf.name = 'user_login_count' in /xxxxx/xxxxxxx/drupal-6.9/sites/all/modules/user_stats/user_stats.install on line 196.
Comments
Comment #1
Critical Tinkerer CreditAttribution: Critical Tinkerer commentedI got the same error when I ran update.php.
The updater went on to report the following:
(Note the "Failed" error.)
Comment #2
Junro CreditAttribution: Junro commentedIdem :)
Comment #3
Junro CreditAttribution: Junro commentedI had to restore a backup....
Fatal error: Cannot redeclare user_stats_preprocess_author_pane() (previously declared in /home/pariscin/www/sites/all/modules/user_stats/user_stats.module:691) in /home/pariscin/www/sites/all/modules/user_stats/user_stats.author-pane.inc on line 21
Got this with all pages.
Comment #4
gaele CreditAttribution: gaele commentedWas this ever tested?
user_stats.install line 194:
CAST(pv.value AS INT)
should be:
CAST(pv.value AS SIGNED)
Comment #5
Liam McDermott CreditAttribution: Liam McDermott commentedObviously not. I did as much testing as I could think of during development (but using PostgreSQL, where it works perfectly), Then put up a -dev version on the project page and asked people to test the module out. I left it like this for seven days, before creating a release with a note in both the release notes and on the project page saying:
and:
Seriously, there's no way to test contrib code other than just pushing it out and seeing what bugs are raised. Please don't whinge, I gave fair warning, asked people to test the -dev version and advised people to test the beta before deploying it on live sites!
So, no, it wasn't tested! :)
Comment #6
digemall CreditAttribution: digemall commentedSame error for me.
Comment #7
Liam McDermott CreditAttribution: Liam McDermott commented@digemail: wow, we must have posted at exactly the same time and your post reset the status. Fixing. :)
I've created a new release, which will be on the project front page in the next five minutes, or so.
Comment #8
digemall CreditAttribution: digemall commentedAmazing ! :P
thx for the fix, I'll test it now.
And I hope the bug with author_pane integration it's fixed too, otherwise I'll report to you immediately ;)