forum doesn't works [#388844]

Comment #2

v8powerage CreditAttribution: v8powerage commented 2 March 2009 at 20:47

Problem is in forum-list.tpl.php and topic-list.tpl.php

I changed this

      $rows[] = array
        (
        array('data' => $description, 'class' => 'forum'),
        array('data' => $forum->num_topics . ($new_topics ? '<br />'. l(format_plural($new_topics, '1 new', '%count new'), "forum/$forum->tid", NULL, NULL, 'new') : ''), 'class' => 'topics'),
        array('data' => $forum->num_posts, 'class' => 'posts'),
        array('data' => _forum_format($forum->last_post), 'class' => 'last-reply'),
        );

Into this

      $rows[] = array
        (
        array('data' => $description, 'class' => 'forum'),
        array('data' => $forum->num_topics . ($new_topics ? '<br />'. l(format_plural($new_topics, '1 new', '%count new'), array("forum/$forum->tid", NULL, NULL, 'new')) : ''), 'class' => 'topics'),
        array('data' => $forum->num_posts, 'class' => 'posts'),
        array('data' => _forum_format($forum->last_post), 'class' => 'last-reply'),
        );

But I'm getting printed %count new instead of 'number' new topics, and there is N/A instead last author.

Log in or register to post comments

Comment #3

fgm

French

Paris, France

CreditAttribution: fgm commented 3 March 2009 at 09:22

Priority:	Critical	» Normal
Status:	Active	» Needs work

The change you are suggesting does not match the signature of function l() http://api.drupal.org/api/function/l/6

You are effectively invoking l('some plural title', array(...)), although the second parameter to l() is a path, like "forum/$forum->tid" in the current version.

However, there is indeed something fishy here since the current version passes three more parameters to l(), as it used to in D5, but this is D6 and l() only takes three parameters now. I don't have time to fix this for now, but you can at least try:

 array('data' => $forum->num_topics . ($new_topics ? '<br />'. l(format_plural($new_topics, '1 new', '%count new'), "forum/$forum->tid") : ''), 'class' => 'topics')

Although this loses the "new" attribute, it should resolve the problem you are encountering.

Removing criticality as this does not prevent the theme from working on essential pages.