The latest version of the i18n module (6.x-1.0) provides a Switch interface for translating option to...
...switch interface language to fit node language when creating or editing a translation. If not checked the interface language will be independent from node language
This is very convenient for multiple reasons, e.g. for using views with a Node translation: Language filter set to Current user's language for node reference selections.
It would be nice if the translation overview also checks whether the user wants to switch the interface language to the node language. I created a minor patch which takes care of this. It seems to work fine.
Comment | File | Size | Author |
---|---|---|---|
#2 | translation_overview-390756.patch | 3.13 KB | netsensei |
Comments
Comment #1
drewish CreditAttribution: drewish commentedhumm. the code all looks good but i've got some issues with the comments, also i can't get the patch to apply for some reason.
couple of small things to fix:
Capitalize the F in for. The question might be better as a TODO...
I think we need to indicate the type of $interface_language, perhaps by saying "$interface_language Boolean indicating that"
The second line needs another space after the *.
Needs a period at the end of the sentence. Comments should wrap at 80 character long lines.
Comment #2
netsensei CreditAttribution: netsensei commentedWe needed this functionality for a project.
If you use Node References in nodes that can be translated, the entire interface needs to switch if you want to translate a node. Otherwise you might end up referring node A in language 1 from node B in language 2. Node reference will not play with i18n and trying to save the node will throw a "cannot save this node" error.
i.e. #186539: Node reference fields- This post can't be referenced
I've rerolled the patch against the dev version of translation_overview.
Comment #3
FiNeX CreditAttribution: FiNeX commentedThe same issue is valid on the D7 version: "switch interface" setting is not honoured by translation overview.
Comment #4
miro_dietikerneeds review again then.
Comment #5
jmones CreditAttribution: jmones commentedAs #3 I have the same issue on D7. Patch on #2 doesn't apply on D7 code. Target code has changed.
Thank you for your work.
Comment #6
ali_b CreditAttribution: ali_b commentedsame issue in 7. could someone fix it?
Comment #7
james.williams CreditAttribution: james.williams at ComputerMinds commentedIssue #1698840: Wrong links on node translations overview page is also covering the same problem, though without offering it as an toggleable option.