create a stable version for the 6.x branch of the login_security module

After two months of posting (I also did buzz in other forums) I got no answer for suggestions, so the last step I can take is to create a new release and hope people would read the release notes about this issue..

To get the stable release I would like to remove non used functionality, and do some changes to current one to fit the needings, so I guess completing this step is necessary for the -1.0

Thanks to deekayen, the current status to achieve the goal now is:

#400156: simpleTest test case
#399390: database schema and operations clean up
#495226: Login attempts message inconsistent
#493164: Incorrect redirection when you are banned
#492800: Incorrect table definition
#492600: Last login doesn't display
#316736: remove any indication of authentication failure until logon attempt is complete
#366172: Translation msgid correction
#326887: login handler still shows login tracking
#496446: Administration interface tough love
#496448: Review/Create module documentation

Now that code is not going to be hardly touched, I guess the next action will be create a beta or rc release for people to be warned about.. hopefully some more 'real life' testing could happend before the 1.0 version.

for a quick review..

#400156: simpleTest test case
#399390: database schema and operations clean up
#495226: Login attempts message inconsistent
#493164: Incorrect redirection when you are banned
#492800: Incorrect table definition
#492600: Last login doesn't display
#316736: remove any indication of authentication failure until logon attempt is complete
#366172: Translation msgid correction
#326887: login handler still shows login tracking
#496448: Review/Create module documentation
#500358: Variable %username is not populated right to watchdog
#499788: Time track depending on cron is not accurate
#501040: Add link to blocked user accounts
#500740: Review translatable strings for login_security_t()
#496446: Administration interface tough love

I'm happy, unless a new important bug appears, this list will be the roadmap for the 1.0, and patches are there :)

In my opinion, It's safe to use have installed and enabled. The only part not clear at all is "how can you make your site unestable with this module" when you set a risky configuration with the options of this module. This will be included in the last version of the README.

The fixes we are dealing with (appart from the cron timestamp behaviour) are in most cases usabiltity and cosmetic changes, I guess.. In any case, I think this is now a matter of days to get a jump from beta to 1.0 version skiping.

If there are no concerns, we can get a rc1 with the bug fixes (current list), and leave cosmetic issues (anarcat's proposal) for the 1.0.

PD: just came back from vacations today :)

So, now that we have commited most of the main changes, I guess we can the last effort.. wording, string consolidation and translation and (not sure) some final administration interface changes. These are important but will not break anything, so as commented by drupaloo @6 I have moved the job done into the RC1 release.

These are the current issues about this changes, once we agree in them we could have the (so desired for me) 1.0 version. Still there are some discussions about installation messages, more documented interface and so, lets close them!

#536952: Create own settings page under admin/settings/login_security
#536954: Improve inline documentation of admin interface
#500740: Review translatable strings for login_security_t()

and maybe, we may reopen:
#496446: Administration interface tough love

C'mon! the last stint is almost finsihed.. the 1.0 is quite close now :)

This is the list of changes up to now.

#400156: simpleTest test case
#399390: database schema and operations clean up
#495226: Login attempts message inconsistent
#493164: Incorrect redirection when you are banned
#492800: Incorrect table definition
#492600: Last login doesn't display
#316736: remove any indication of authentication failure until logon attempt is complete
#366172: Translation msgid correction
#326887: login handler still shows login tracking
#496448: Review/Create module documentation
#500358: Variable %username is not populated right to watchdog
#499788: Time track depending on cron is not accurate
#501040: Add link to blocked user accounts
#500740: Review translatable strings for login_security_t()
#496446: Administration interface tough love
#536952: Create own settings page under admin/settings/login_security
#536954: Improve inline documentation of admin interface
#558624: When using feature "Increase delay for each attempt" no logins are possible anymore
#583332: "notify" email will be renamed to "block_user_notify"
#583092: Ongoing attack detection: log activity and send email to admin after a number of failed login attempts..
#583104: Provide Drupal / Drush interface to clear banlists
#583978: Consolidate strings and grammar and export .pot file

The last task is the easy part..

I would expect some feedback after all this effort. This last issue is quite important, so I hope you could provide some input.

oh... this one was so hard to get on :)

Finally it's here, we now have a 1.0 version of the module that is pretty stable. I've created a contrib documentation module handbook, and the new interface with descriptions as suggested by anarcat should do the rest. A last minute bug was also fixed regarding the 5.x to 6.x upgrade path, so I feel happy marking this issue as fixed right now!

:)

thanks to all how helped to get this release published!