Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Reproduce:
- add feed to aggregator
- go to aggregator/sources/1
Next to the URL: label you will see a link to your own site. The reason is that aggregator hasn't downloaded the feed yet and the feed link (link to the feed's web site) is not available yet.
Patch follows asap.
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | drupal-aggregator-fix-link-397962-20-D7.patch | 3.63 KB | smussbach |
| #13 | drupal-aggregator-fix-link-397962-13.patch | 3.54 KB | rootwork |
| #7 | 397962_fix_feed_link.patch | 2.73 KB | alex_b |
| #1 | 397962_fix_feed_link.patch | 1.97 KB | alex_b |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedComment #2
alex_b CreditAttribution: alex_b commentedComment #3
alex_b CreditAttribution: alex_b commentedComment #4
alex_b CreditAttribution: alex_b commentedComment #5
alex_b CreditAttribution: alex_b commentedPassed test bot, simple fix, setting it to RTBC.
Comment #6
Dries CreditAttribution: Dries commentedIf the feed hasn't been downloaded yet, shouldn't we skip the description, image, and friends too? The code is somewhat inconsistent -- for the 'checked' check we use a regular if-statement. It feels like this can be cleaned up further, maybe even with a test update.
Comment #7
alex_b CreditAttribution: alex_b commented#6 - that's right... this patch hides any information retrieved from feed if the feed hasn't been updated yet - much cleaner.
Comment #8
alex_b CreditAttribution: alex_b commentedLet's hold on this one for the moment. #293318: Convert Aggregator feeds into entities may completely change template_preprocess_aggregator_feed_source() anyway.
Comment #9
Jody LynnComment #10
jibranas per #8
Comment #11
Aron NovakShould be after #1896060: aggregator.module - Convert PHPTemplate templates to Twig, not?
Comment #12
rootworkTook a stab at updating this. First I confirmed that it is still true in Drupal 8 -- if the feed hasn't been retrieved yet, it will display your own site's address as the feed address.
I made the corresponding changes to the aggregator page and the new Twig template, but it's not functioning yet -- I suspect because I'm not yet familiar with how variable checking in Twig works. If you someone else wants to try to get it to work, that's where I'd start.
Setting to needs review so the testbot will run, but it needs more work.
Comment #13
rootworkOops. Here's the real patch.
Comment #15
rootwork13: drupal-aggregator-fix-link-397962-13.patch queued for re-testing.
Comment #17
rootwork13: drupal-aggregator-fix-link-397962-13.patch queued for re-testing.
Comment #18
znerol CreditAttribution: znerol commentedThis was fixed by #2261425: Streamline aggregator's entities rendering with rest of core for Drupal 8.0.x. Still an issue in 7.x, though.
Comment #19
rootworkComment #20
smussbach CreditAttribution: smussbach commentedHere is the patch ported for D7