The recent backport of core comment-settings usage broke the 5.x version completely. I just downloaded the module for my 5.x site, and it does literally -NOTHING-.

The problem is, that the code attempts to work with the 6.x per-node-type comment settings, which don't exist on 5.16 entirely! The 5.x core have a site-wide setting instead. Currently, Flatcomments 5.x-1.2 check a non-existing variable, and alter a non-existing form-element, resulting in no action being performed at all.

In my opinion, this doesn't change anything about the rationale of tying display- and flatcomments-settings together, but a 5.x-specific fix is highly needed.

Attaching a patch: Correct site-wide setting checked, correct admin-form altered (for 5.x at admin/content/comment/settings), plus a comment updated to reflect the setting being *not* per-node-type, and also being just "flat comments" generally, as oposed to "flatcomments" module specific (not true anymore).

Patched version works fine on my site.

CommentFileSizeAuthor
flat-5-x.patch1.26 KBJirkaRybka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dragonwize’s picture

Status: Needs review » Fixed

Committed. Thanks, shows how much I remember of D5, I could have swore that was the same.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.