RTL support for comment notify [#402490]

Attached is an RTL (right-to-left) version of the comment_notify CSS file.
The file is automatically for RTL loaded by RTL-aware themes - no code changes needed.

This is tested on both IE and firefox.

Please upload the file as comment_notify-rtl.css to the main comment_notify directory.

Also, I've added a patch to the original CSS file, comment_notify.css, which simply adds the /* LTR */ comments for rules which only apply for LTR languages (That's the recommended convention, so that anyone altering the original CSS will be aware of the fact).

The patches were for version 6.x-1.2.

Please upload.

Thanks in advance,

Amnon
_{-

Professional: Drupal Israel Co-Funder | Drupal Development & Consulting

Personal: Hitech Dolphin: Regain Simple Joy :)}

File	Size	Author
comment_notify.css_.patch	964 bytes	druvision

comment_notify-rtl.css_.txt	236 bytes	druvision

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 16 March 2009 at 12:36

Status:

Reviewed & tested by the community

» Needs work

The files have changed slightly since 6.x-1.2 because of #399806: Wrap the comment-notify form elements in a DIV and remove needless br.

Can you confirm these work for the latest code from the 6.x-1.x dev code?

Comment #2

druvision CreditAttribution: druvision commented 26 March 2009 at 18:30

Status:

Needs work

» Reviewed & tested by the community

The patch format make it hard to understand. All I asked to do in the original CSS file is to add LTR comments after the margin-left and float rules. This will just make it easier to understand. Here is it should look (the patch was re-applied on the latest version):

/* $Id: comment_notify.css,v 1.3 2009/03/12 17:07:05 greggles Exp $ */
#edit-notify-type-1-wrapper, #edit-notify-type-2-wrapper {
  float: left; /* LTR */
  display: inline;
}

#edit-notify-type-1-wrapper {
  margin-left: 2em; /* LTR */
}

#comment-notify .form-radios {
  overflow: hidden;
  height: 100%;
}

#edit-notify-type-2-wrapper {
  margin-left: 1em; /* LTR */
}

Of course, please commit the 1st file, comment_nofity-rtl.css, as well

Comment #3

greggles

he/him

English

Denver, Colorado, USA

CreditAttribution: greggles commented 31 March 2009 at 23:28

Title:	RTL support	» RTL support for comment notify
Status:	Reviewed & tested by the community	» Fixed

Great then, I've committed this (the patch didn't work but it's not a big change). Please let me know if there are any problems with the final results.

There's no reason to backport this to 5.x, right?

Thanks for your help!