Hello,

I'm using TinyMCE 3.2.2.

In Firefox 3.0.7 page break works ok but in IE7 only the break image is inserted in the editor but the break code not. It doesn't work in previous versions of TinyMCE either.

With best regards,

Fred

Thanks for this great module!

CommentFileSizeAuthor
#10 wysiwyg-HEAD.break-comment-ie.patch1.44 KBsun
#7 wysiwyg-HEAD-issue-404532.patch766 bytesTwoD
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Postponed (maintainer needs more info)

What kind of "pagebreak" are you talking of?

fredklopper’s picture

fredklopper CreditAttribution: fredklopper commented

Drupal break: <!--break-->

Arjean-1’s picture

Arjean-1 CreditAttribution: Arjean-1 commented

I can confirm this.
The page/teaser break button works perfect in Firefox, you can add it to a new/edit node and it will be stored.
As for IE7 it is already being filtered out at a preview.
When editing a post (having working teaser break) in Explorer 7 it will show the teaser break,
but every edit afterwards will make it disappear.

k3vin’s picture

k3vin CreditAttribution: k3vin commented

subscribing

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Page break in IE7 » TinyMCE/FCKeditor: Teaser break vanishes in IE6/7
Status: Postponed (maintainer needs more info) » Active
TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD commented
Component: Editor - TinyMCE » Plugins

I did some testing in IE6 and it turns out that IE does not allow comments to be inserted the way we do it in the Break plugin.
The plugin uses $('img.wysiwyg-break', $content).replaceWith('<!--break-->'), which in turn calls this.after('<!--break-->'). Wrapping the comment in something, like <p><!--break--></p> seems to work though, but I'm not sure if it'll treat it as text or an actual comment though. I don't have access to my own computer at the moment but will test this again in a few hours.

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD commented
FileSize
wysiwyg-HEAD-issue-404532.patch766 bytes

I've created a simple patch and tested it in IE7. It should also work in IE6 (and all other major browsers) since document.createComment() was introduced to the standards back then.

Arjean-1’s picture

Arjean-1 CreditAttribution: Arjean-1 commented

Tested it in IE 7, Firefox 3 and Opera 9, seems to work fine. Well done.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Needs review
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Fixed
FileSize
wysiwyg-HEAD.break-comment-ie.patch1.44 KB

Thanks for testing!

Committed attached patch to all 2.x branches.

We should always add remarks for compatibility issues like this.

fredklopper’s picture

fredklopper CreditAttribution: fredklopper commented

Well done, thanks!!!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD commented

For the record, related error in #474908: Teaser Break: IE8: JavaScript error. That fix must not break IE6/7 again.

abz789’s picture

abz789 CreditAttribution: abz789 commented

Hey guys, i was having same issue and finally managed to crack it down by placing the following code..


            strReturn = "<div style=""page-break-after: always""></div>"
            strReturn += "<br style=""height:0; line-height:0"">"

and then value what ever it is.

It worked for me.

FF was already working fine, its just MICRoSOFT always :)

TwoD’s picture

TwoD
Primary language Swedish
Location Sweden
CreditAttribution: TwoD commented

@abz789 I fail to see how that code is related to the plugin inserting <!--break--> comments used by Drupal to split a node's teaser and body.
This issue has been fixed in most browsers for some time now, and just recently it was also fixed in IE8, are you perhaps thinking of another issue?