My site slogan is 'Leaning & Development', however the & is not being being html encoded as &
Page titles with '&' in are correctly encoded.

CommentFileSizeAuthor
#7 page_title-6.x-2.2-fix_html_in_slogan.patch379 bytespeter.walter
#6 page_title-fix_html_in_slogan.patch367 bytespeter.walter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

peter.walter’s picture

peter.walter CreditAttribution: peter.walter commented

First line should have read
'My site slogan is 'Leaning & Development', however the & is not being being html encoded as &

nicholasThompson’s picture

nicholasThompson
Primary language English
CreditAttribution: nicholasThompson commented
Version: 6.x-2.0 » 6.x-2.x-dev
Assigned: Unassigned » nicholasThompson
Priority: Normal » Critical

I'll take a look - thanks.

nicholasThompson’s picture

nicholasThompson
Primary language English
CreditAttribution: nicholasThompson commented
Version: 6.x-2.x-dev » 5.x-2.x-dev
Status: Active » Patch (to be ported)

Fixed in commit http://drupal.org/cvs?commit=195366
Will be in DRUPAL-6--2-1

Fix needs porting...

nicholasThompson’s picture

nicholasThompson
Primary language English
CreditAttribution: nicholasThompson commented
Status: Patch (to be ported) » Fixed

Fix is present in DRUPAL-5--2 and DRUPAL-6--2... Marking as fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

peter.walter’s picture

peter.walter CreditAttribution: peter.walter commented
Version: 5.x-2.x-dev » 6.x-2.2
Assigned: nicholasThompson » Unassigned
Priority: Critical » Normal
Status: Closed (fixed) » Needs review
FileSize
page_title-fix_html_in_slogan.patch367 bytes

Not fully fixed - see patch attached

peter.walter’s picture

peter.walter CreditAttribution: peter.walter commented
FileSize
page_title-6.x-2.2-fix_html_in_slogan.patch379 bytes

Sorry, error in patch file (and can't edit attachments) - this one should be correct

nicholasThompson’s picture

nicholasThompson
Primary language English
CreditAttribution: nicholasThompson commented

I believe that was removed as it has a tendency to double-encode...

peter.walter’s picture

peter.walter CreditAttribution: peter.walter commented

Ah yes - it does double encode the node title, but require this patch to get the site slogan (as defined in the original issue at the top) to encode properly.

peter.walter’s picture

peter.walter CreditAttribution: peter.walter commented

It's a hacked solution, but I can get the script to encode my <title>'s properly by using this as the return at the end of page_title_page_get_title():

447: return check_plain(html_entity_decode(strip_tags($title)));

Peter

13rac1’s picture

13rac1 CreditAttribution: 13rac1 commented
Title: Site slogan in <title> is not being encoded » HTML tags and entities shown in <title>
Version: 6.x-2.2 » 7.x-2.x-dev
Status: Needs review » Needs work

I'm surprised this problem still exists. I set #1278262: HTML in page title and #1285122: HTML Entities in Title as dupes of this.

I get HTML in the page title simply by enabling this module.

  1. Enable Page Title
  2. Disable Overlay
  3. Edit any node
  4. Check the page title to see: <em>[Content Type]</em> - [Node Title]
dgastudio’s picture

dgastudio CreditAttribution: dgastudio commented
Priority: Normal » Major

same here