I have a taxonomy created through the NAT module. This Taxonomy is unsorted. It would be nice if you add a "Sort order" option for this module.

I think as your module is for displaying and choosing options from a List it would be a nice feature. Maybe this could be driven further and you could add JS options for searching and sorting in the current list.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

attheshow’s picture

Status: Active » Closed (won't fix)

Sorry, this is not a feature that is not implemented by any other built-in CCK widgets, and therefore goes beyond the scope of this module.

cyc’s picture

Version: 6.x-1.2 » 6.x-1.x-dev
Status: Closed (won't fix) » Active

unfortunetely you are wrong:

http://drupal.org/project/nodereference_views_select allows sorting of multiple selected values

please rethink your statement..
sorting will be very helpful option

attheshow’s picture

Status: Active » Closed (won't fix)

You're referencing a third-party project. That's not part of the CCK built-in module set. In any case, this is not something that I'll personally be working on, so the status should remain as "won't fix". Please do not change the status unless you yourself plan to create a patch that provides the functionality you want.

cyc’s picture

@attheshow,

sorting may be "not implemented by any other built-in CCK widgets", but generally may be implemented in third party cck widget.

your module provides "third party" cck widget - exactly as nodereference_views_select module does.

if this means you are not going to implement sorting into your module, I can only say: it's a pity:-(

suedehead’s picture

I know this discussion is old, but the nodereference autocomplete widget, which is _not_ a third-party widget (built into nodereference) enables sorting. See this comment.

If Multiselect had sorting, it would be an amazing module. As it is now, it's still great, but I don't see the functional difference between multiselect, and a list of checkboxes (css styled to be within a scrolling window).

attheshow, do you have any thoughts on possibly enabling sorting at all, seeing as now it's implemented by a built-in CCK widget?

kiwad’s picture

any way to do this with another module, a patch or some custom code ?

feuillet’s picture

Would like to see a sorting option too.

dsnoeck’s picture

Version: 6.x-1.x-dev » 7.x-1.9
Assigned: Unassigned » dsnoeck
Status: Closed (won't fix) » Needs review
FileSize
2.48 KB

Here is a patch for this feature.

Enjoy

- Damien

sir_squall’s picture

Nice patch :)

goldlilys’s picture

Awesome #8 for that patch. Thanks. Hopefully, this can be included in the next release. Works well enough to sort and order the terms around.

goldlilys’s picture

Issue summary: View changes

Why hasn't this been included with the new releases yet? It's highly desired.

broon’s picture

Version: 7.x-1.9 » 7.x-1.x-dev
FileSize
8.34 KB
552 bytes
567 bytes

Based on #8's patch, I created a patch against the current 7.x-1.x-dev version and included some style changes to make the UI more clear. I also included two new icons for the move up/down button but these are rather simple and should probably be rebuilt to be in line with the existing ones.

broon’s picture

Sadly, no one reviewed the patch and now there has been a new release. Nothing important changed from 1.12 to 1.13, .module and .js files have not been changed, just some CSS. So the patch does not work with the new CSS file, the rest remains.

@attheshow: Should there be a review or are you still holding to "Won't fix"?

attheshow’s picture

Assigned: dsnoeck » Unassigned
Status: Needs review » Needs work

@Paul Broon Hey! I'm open to the sorting patch now that someone else has put some effort into it. I noticed that in #12 some CSS flex changes were brought into the patch. The patch should probably be re-rolled without those included. If you want to open a separate ticket regarding the CSS flex changes and create a separate patch to include those, that would probably make the most sense since they don't relate to this particular ticket.

broon’s picture

The main reason for the flex stuff was due to how the layout of the multiselect worked and how my client wanted to have the icons show up. Also, as mentioned in #12, the buttons I chose for moving an item up/down are not really related to the original multiselect module. Do you have suitable icons in your icon set where you took add/remove from?

I'll try to generate a new patch against 1.13, but as I am skiing next week, this might be around mid-February, only.

attheshow’s picture

Yeah, those are quite a bit different. No the add/remove icons were custom-designed by a designer that I worked with quite a few years ago.

thanasis00’s picture

FileSize
6.64 KB
175 bytes
180 bytes

Hi guys,

I needed to use the sorting functionality, so I tried to apply the patch provided by Paul Broon above to the latest module version (1.13). I fixed all the css issues tha arised from the patch, and now it seems to be working and looking ok.
I also changed the move up and down icons to some more discreet, but you can replace it again if you want.

Sorry if I omitted anything from the contributing format.

thanasis00’s picture

FileSize
7.71 KB

I have updated once more the codebase. There was an issue when you used this module with mforms. It would not render the sorting arrows.