Outdate jQuery selectors [#428824]

The selectors used within the og_access.js file are outdated (the "@" should not be used anymore) and the script breaks if used with the versions above 1.3 of jQuery (as provided in jQuery Update).

It is a common problem found in various other modules too.
Just a small note: I used a search and replace (in Eclipse) with regex to correct
search: ^(.*\[)@(.*)$
replace $1$2
Et voilà. I hope It helps and keep on the great work on OG!

Comment	File	Size	Author
#2	og_access_js.patch	6.53 KB	jcmarco
#2
	og_access_jquery_selector.patch	6.7 KB	zeropaper

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 9 April 2009 at 20:28

Status:

Patch (to be ported)

» Needs review

can anyone confirm that this works with old and new jquery?

Comment #2

jcmarco CreditAttribution: jcmarco commented 15 April 2009 at 18:07

File	Size
og_access_js.patch	6.53 KB

I found this issue when I was checking the status of this issue:
#358082: jQuery 1.3 in Drupal 6.x

I have been testing removing all @name in the og_access.js, with jquery_update (JQuery 1.3.1) and with standard Drupal JQuery (1.2.6) and the patch always works fine,
the bug was always in the node edit screen where you need to select the groups to publish the node.

In my case I used this patch that is exactly the same that zeropaper's one but done with diff instead eclipse.