Add code to allow the getclicky module to be configured to either:

1) Not track secure pages (thereby avoiding the pop-up browser warning that the page contains mixed http and https references)
or
2) Track secure pages correctly using https urls in the tracking code and changing the java script url to .secure.js when the page is a secure page. Note that tracking secure pages requires a getclicky pro account.

I have attached a modified version of the getclicky.module from 6.x-1-1 which adds the needed configuration option and support for secure pages.

This modified version will no longer cause the browser pop-up warning regardless of whether it is configured to track or not track secure pages. If configured to not track secure pages, the getclicky code is not added in the footer of any secure pages. If configured to track secure pages it will now detect when a page is a secure page and will use https urls and will use the secure version of the getclicky java script. I don't have a getclicky pro account so I haven't been able to verify that the secure page tracking works correctly for a pro account.

This is my first submission of open source software, and I am not sure if this is the correct way to submit this change. Please let me know if it should be done in a different way.

CommentFileSizeAuthor
getclicky.tar_.gz3.06 KBskyhigh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Zach Harkey’s picture

Category: feature » bug
Priority: Normal » Critical

+1 This fix works.

Changed to Bug report because as it stands, this module is completely unusable with HTTPS.

rsvelko’s picture

this will be commited soon. I've just become the new maintainer. Cheers.

rsvelko’s picture

1. examine this
2. see about the new ssl js code clicky offers

rsvelko’s picture

Status: Active » Fixed

ok, I commited a solution based on this patch above! MAde a release too.

I used also the newest js code from the clicky site to inspire me - got the best out of the 2.

Please update to the latest green version and report... (rc2)

Does all work now?

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.