Wrong anchor tag to comment [#433208]

Link to new comment with #anchor genarated not correctly. String
array('attributes' => array('title' => $comment->subject, 'fragment' => 'comment-'. $comment->cid))

must be
array('attributes' => array('title' => $comment->subject), 'fragment' => 'comment-'. $comment->cid )

I found some missing translation, but I'm not shure that my fix is correctly (it's work for me). Please review patch.

Comment	File	Size	Author
#4	userpoints.module.patch	1.43 KB	dicreat
#4
#2	userpoints.module.patch	779 bytes	dicreat
#2
	userpoints.module.patch	1.61 KB	dicreat

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kbahey CreditAttribution: kbahey commented 14 April 2009 at 15:36

Title:	Missing translation and wrong anchor tag to comment	» Wrong anchor tag to comment
Status:	Needs review	» Needs work

t() should not be used on variables, only literal strings.

See details here http://groups.drupal.org/node/15177

You can submit a revised patch for the anchor issue only.

Comment #2

dicreat CreditAttribution: dicreat commented 15 April 2009 at 07:21

File	Size
userpoints.module.patch	779 bytes

Ok, thanks.

Comment #3

kbahey CreditAttribution: kbahey commented 15 April 2009 at 12:35

The patch does not apply cleanly. Please follow the instructions at http://drupal.org/patch for details.

Also, if you search the module you will find another instance of _comment_load(). Does the lines following it need to be fixed to? If so, please reroll the patch with a fix for that line as well.