Set to Tweet when Published, even via Scheduler

Maybe this helps: Scheduler issues the "publish_node" ("node_publish"??) action when publishing nodes...

I think the same problem is with scheduler - twitter do not publish twit
SUbscribing

I have the same problem. By default stories are set to unpublished & tweet. I set a scheduled publish on date, and when it passes they publish but no tweet.

Subscribing.

Me too...

This option should be placed in the content type settings. (auto)tweet on publishing - like the publish on startpage default option and only users with the right permission can change it on creating/editing nodes.

Subscribing

I too would like to see this fixed/implemented. Right now, unfortunately the autotweet feature is useless for me.

Subscribing

Subscribing. I would definitely appreciate this one too, thanks.

+1

For sites with workflows most content takes some time to publish.

When using the shorten module to get short URLs, is it the the URL alias or the /node/x that is used?

This is quite important as with our content the title often change before an article has passed all stages in the workflow. It is quite common that an editor changes the writers suggested title and thus also the URL alias will change.

Therefore not only should the tweet only go out when the node is published, the shorten URL should also be generated at that point.

Indeed, not publishing scheduled posts is a missing feature, almost a bug I would say.

Subscribing

oops doublepost

This is what happens when a node is published immediately:

hook_nodeapi() $op = validate, status = 1
hook_nodeapi() $op = presave, status = 1
hook_nodeapi() $op = insert, status = 1
story: added publishtest.

This is what happens when a node is published via scheduler:

hook_nodeapi() $op = load, node->status = 0
Action: "Set Story optest to published."
hook_nodeapi() $op = presave, node->status = 1
hook_nodeapi() $op = update, node->status = 1
Action: "Saved Story optest"

Looks good so far. twitter_nodeapi switches on insert and update and does the same thing for both cases. The only reason for not posting a status update is this line (line 114 in twitter.module 1.3.2.16):

if (!empty($node->status) && !empty($node->twitter) && !empty($node->twitter['post'])) {

$node->status should never be empty and neither should $node->twitter. But what about $node->twitter['post']? What should it contain and when?

Oh, wait a minute! $node->status is empty when it is created without being published. So no status update in this case and right so. twitter_nodeapi() assumes it is called when the node is created. $node->twitter will be empty, if a node is loaded later, e.g. for scheduled publishing. The problem is the missing switch-case for $op == "load". This should be implemented to load the twitter module stuff into $node->twitter. This should be done anyway or all kinds of other stuff fails...

There is even more: On $op == "insert" and $op == "update" it should save the content of $node->twitter for later use (e.g. editing unpublished nodes and defered publishing which both would need $op == "load" to work properly).

Is there any solution for this problem so far? Subscribing ...

Subscribing.

The ability to post to Twitter based on "published" state is crucial for sites using workflow and/or scheduled posting.

subscribing...

subscribe

subscribing +1 for this feature

Subscribing

I am having the same issues.

I've tweaked my Twitter module to work with the Bit.Ly api which is awesome ('cause I get those great stats and kwel dashboard)

It works fine when I just publish the Node. But I am using the Scheduler Module (which is again awesome) to keep fresh content flowing through the website all day long & reduce the work load.

What Happens is when I Submit the Node. Even though it's not Published a Shorted URL gets generated (I know this from the Bit.Ly dashboard) and then when in actual the node is published !!! It gives an Error.

Twitter Module simply Rocks 'cause it reduces the work load so much. Specially if you publish a lot of News like content & with Scheduler ur life gets even better. Hope this issue is fixed ASAP.

+1

subscribe +1

I made a small module that calls the scheduler api right after the node is published. It' s tested with the new twitter 6.x-3.0-beta2 + oauth-6.x-2.02

The only thing you need is to register your own application at twitter (the normal procedure for oauth authentication)

And the id of the user which will post the tweets. You can find your id from your tweeter rss feed.

The largest part of the code is from the tweeter nodeapi hook. I made some changes so I can get reports from watchdog etc.

/**
 * Implementation of hook_scheduler_api().
 *
 * If the scheduler publishes a node then it should post to twitter too.
 */

function csi_tools_scheduler_api($node, $action) {
	if ($action == 'publish') {
				module_load_include('inc', 'twitter');
				$twitter_account = twitter_account_load('your_tweeter_id_here');
				
				$replacements = array('!title' => $node->title,
                              '!url' => url('node/'. $node->nid, array('absolute' => TRUE, 'alias' => TRUE)),
                              '!url-alias' => url('node/'. $node->nid, array('absolute' => TRUE)),
                              '!user' => $node->name);
        // Only generate the shortened URL if it's going to be used. No sense
        // burning through TinyURLs without a good reason.
        /*if (strstr($node->twitter['status'], '!tinyurl') !== FALSE) {
          $replacements['!tinyurl'] = twitter_shorten_url(url('node/'. $node->nid, array('absolute' => TRUE)));
        }*/

        //$status = strtr($node->twitter['status'], $replacements);
        if (!empty($node->taxonomy) && !empty($node->taxonomy['tags'])) {
          foreach ($node->taxonomy['tags'] as $tag) {
            $category = $tag;
          }
          $node->twitter['status'] = "#" . $category . " - " . $node->title . " >!tinyurl";
        }
        else {
          $node->twitter['status'] = $node->title . " >!tinyurl";
        }
				
        $status = strtr($node->twitter['status'], $replacements);
        try {
          $result = twitter_set_status($twitter_account, $status);
          watchdog('csi_tools', 'Successfully posted to Twitter', array(),  WATCHDOG_NOTICE, l(t('view'), 'node/'. $node->nid));
        }
        catch (TwitterException $e) {
          watchdog('csi_tools', 'An error occurred when posting to twitter: %code %error', array('%code' => $result->code, '%error' => $result->error), WATCHDOG_NOTICE, l(t('view'), 'node/'. $node->nid));
        }
				
				watchdog('csi_tools', '@type: publishing the node %title on twitter.', array('@type' => $node->type, '%title' => $node->title), WATCHDOG_NOTICE, l(t('view'), 'node/'. $node->nid));
	
	}
}

#22, It is a nice solution. But there is one problem.

[solved] it was a typo
if ($action == 'publish') { doesn't work. Can't figure out whats the problem. But action is empty everytime.

Does anyone else has this problem?

When you use the function at #22 isn't a problem that cron triggers scheduler and cron is running as a anonymous user.
You get all the watchdog messages but nothing turns up in twitter.

Can you tell me how you're permissions are set for twitter?

Just switched to the OAuth/Twitter combo and started using Scheduler. Is #22 the current solution for tweeting on a scheduled publish? If so, how do I implement that? Is there any hope for integrating it into Twitter?

I had the same problem with the anonymous user. I solved it by directly giving the user id of my twitter account. This means of course that all the scheduled posts will go under one twitter account.
The problem with twitter module is that it doesn't save anywhere the twitter posts of the non published nodes. So I generate the text automatically to post on twitter.
Any input from the form will be dismissed.

I am managing a multi-user blog where all posts get tweeted to the same account. #22 was exactly what I needed!

Hello to all of you,

please tell me..how do i have to implement the code from #22 ?
Iam a beginner and iam not a pro. I would be please, if anybody can help me urgent.

Thanks in advance :-)

I would like a solution to this problem as well.

#22 by @panigrc is great, if you just want a default tweet going out.

However, I'd like to be able to set the tweet in the node form, and have that status tweeted, rather than a default. This means I'll have to store the status in the database and patch the twitter module so it checks for that value..

I don't think this will be hard, I hope to post a patch this weekend.

@aze2010, you have to stick that code in a custom module. Sorry but it's probably not super-easy for a total beginner. If you have some coding experience it would be no problem, though. http://drupal.org/project/module_builder if you'd like a crack at it.

Now tweets will be saved with the node if the node is unpublished, so the saved tweet can be tweeted when the node is published. It does this by using the variable table. Once tweet is posted, the variable is destroyed.

I've tested this with the Scheduler module, and it works.

Also, if tweet length is too long, the form_set_error is called, and user is given a chance to correct form errors instead of failure and loss of the tweet content. I moved all of the status token replacements into node $op=validate so this could happen.

While I was at it, I noticed that when tweets failed due to length, they reported they had been successfully posted, so I updated the function twitter_set_status to return true or false, and then tracked down all invocations of twitter_set_status and modified the twitter_actions module so that it also logs tweet posting failures to watchdog.

Three files are attached, one is a whole folder patch, that seems to touch all the files, for some reason, updating numeric values in ways that didn't make sense to me.

So I've attached two zip files, one containing patches for each of the three files, the other containing the modded files themselves. For newbies, you can just replace the 3 module files with the unzipped files if need be.

All the patches are to be run from the root of the twitter module.

Hold on testing this. I've found a regression and I'll submit a patch shortly.

See comment #30,

Fixed the regression and tested the module.

I've attached two zip files, one containing patches for each of the three files, the other containing the modded files themselves. For newbies, you can just replace the 3 module files with the unzipped files if need be.

All the patches are to be run from the root of the twitter module.

Running this on my live site. I'm still working out a few glitches. I'll re-roll the patch in the next few days.

Alright, lots of changes, including an uninstall hook, created hooks for both nodeapi update and nodeapi insert, more careful checks and helper functions, created a "get twitter account from user id" function in twitter.inc.

Fixed and improved error reporting, no more silent failure due to tweet length exceeding 140 chars as a result of the replacement variables not being checked by form api. Added a validation hook for this purpose.

Lots of code comments, most not in doxygen format.

Everything should be working, I've been running it for a few days, scheduling and creating tweets, with no problems.

No database updates because all node settings are held in the variables table, which makes patching and testing easier, no re-installation necessary. Also, saved tweets appear in node form so nobody's confused by tweeting. Replacement variables like !tinyurl are generated in validate hook and cached in a variable until insert or update so it is possible to check tweet length with form_set_error. Logging watchdog for programmatic submits (like by scheduler). Full of chocolatey goodness. Melts in mouth, not in hand. Makes Drupal fun for the whole family.

If eaton or walkah wants to roll this into the module, I can move that into a proper database table.

To roll patch, copy patch to modules/twitter, cd there, and patch -p0 < scheduled-tweet-4.patch or replace the files with the files from the zip file.

Moved tinyurl generation and url replacements out of validate hook, because sometimes url does not yet exist.

Abstracted function to estimate tweet length, made replacement system more robust.

Getting closer.

I've been running this for a few days, testing, and it is working well. Anyone care to test?

Lots of bug fixes for twitter core, including accurate reporting of failure upon unsuccessful tweet.

Hi glass.dimly, I've tried replacing the module files from scheduled-tweets-files-5.zip and the post settings admin page is now missing.

@pribeh

Odd. You are talking about the page that lives at /admin/settings/twitter/post? I have this page still on my site, running the code.

Attached is the full module folder which I am using, from which I derived the patch. And, I re-rolled the patch, though there are no changes in it. The files include the new patch, for inspection.

@glass.dimly, I accidentally removed the .inc file. I'm very sorry for making you go through that trouble. Anyway, I have experienced an odd memory leak of some sort using the Twitter 3.x module. Once I determine what that is I will get back to testing your improvements. Thanks a bunch.

Subscribe. I will wait until this code is rolled into the Twitter module.

@glass.dimly, I tested your patch and have a few comments.

I tested the following:

1. PASS: Tweet is posted when publishing is postponed by Scheduler module.
2. PASS: Error message received and no tweet posted when attempting to post a tweet with a pre-expansion character length of > 140 characters.
3. PASS: Error message received and no tweet posted when attempting to post a tweet with a post-expansion character length of > 140 characters.

So, functionality all seems to work. I did find a few small issues however:

1. The default text for the "Announce this post on Twitter" textfield was empty. I checked the Twitter module's settings and I did have default text. Rolling back the patch fixes the issue.
2. Error message is missing nid: "Tweet not posted for node because it was 392 characters in length".

Other small code-level suggestions:

1. Suggest adding a `cache_clear_all('variables', 'cache')` after deleting variables during uninstall.
2. Remove call-time pass-by-references in twitter_post.module as they generate deprecation warnings.

If you re-roll I will re-test.

Subscribe.

Subscribe.

subscribe

#38 Did test it shortly, but i noticed that when you have multiple twitteraccounts it pick the first one automaticly.

Been a number of months but is there any solution for the four issues posted by venutip in#41? I have 6.x-3.0-beta3 installed with the patch from glass.dimly in #35 and see the same issues as mentioned. Been trying to figure it out on my own but no luck so far.

I'm working on cleaning up this patch. It does a lot of things I wouldn't do (and even has TODO's about them) like saving all default statuses in the variables table rather than their own db table.

I'll work on improving this (doing so for a client that needs Scheduled tweets to work).

I will also work on a hook_nodeapi('load') addition that loads the Twitter status into the node object so we can check it in the $node variable as opposed to doing db lookups all the time.

I'll post back a new patch once I have it ready.

Going to change this to Needs Work since I feel the patch provided could use improvement.

Lot of discussion here, could anyone affected by this bug summarize and provide steps to reproduce? This helps me while I look on the issue queue and fix more specific issues.

Cheers

Sure. This is something I've actually just fixed for a client, and I'll work on posting a patch here once I have my kludges fixed.

Assuming you have Twitter modules installed, enabled, and an application connected to your accounts and can post to Twitter from Drupal:

1) Install and configure Scheduler module
2) Create (or edit) a post, select "Announce on Twitter" and set a scheduled "publish on" date.
3) Wait for Cron to run and the node to be published.
4) Tweet will not get published.

I've written a patch that includes a database table which stores Twitter statuses by account and $node->vid, which can then be fired by Scheduler when the hook_nodeapi("update") op is fired. I have a little more work to do but can post my patch here soon as a starting point.

Changing type to feature request. torgosPizza, I look forward for your patch.

Cheers

Cool! I've been working on perfecting it a bit, and need to finish the install/update hooks, as well as an admin config area. (Client needed the module to work with multiple Twitter accounts.)

It'll be an interesting patch, and I might need to break it up into several patches, because it rewrites quite a bit of the module as it stands now.

Will post it very soon!

I am guessing this should be a patch against 6.x-3.dev?

Is there any progress with your patch?

Yes! Sorry, I have been getting sidetracked continuously. Let me clean up what I have and I'll post a patch. Note that it's fairly significant, but I hope to let others work on it some more. I will post it shortly.

Okay, sorry for the delay. Holidays got to me big time! Attached is a patch against 3.0-beta4. Take a look and please get back to me if anything breaks, but this has been in production on mactech.com for a while. It is lacking in some things that could help, like better admin config, etc., but it works for our needs as it stands now.

Updating status.

it doesn't apply to newest version of Twitter module :(

Could you elaborate? The patch I wrote is for 6.x-beta4, not the -dev and not the 7.x. Which version are you testing with?

December 12 version on Drupal 6.

Tried to do it manually to make a patch but I didn't get far.

I don't want to seem ungrateful for all of the hard work going on here, especially for a feature that obviously as lot of people want, but I do have a couple of questions.
1) Why are we using custom fields instead of CCK fields? Using a CCK field will allow us to use Views and be more useful in other modules.
2) I can understand the need for a "tweet time" field, but in my case (and I suspect others) I need to have the tweet occur when the node is published by the scheduler module. Will this be possible?

Thanks for considering these points.

torgosPizza, In latest patch you have used table 'twitter_post_nids', but I don't know table scheme. Can you post this table scheme here?

Thanx for moving this along, but we need the get the patch rerolled against current dev. not beta 4 that is getting old. A lot of code has changed since then.

Update to #61:

I have the Twitter module enabled but no content types are allowed for the Twitter module. I then wrote a small module to use CCK fields which get saved with the node. When the node is published (at creation or later), the Tweet is sent. Also added a CCK field to keep a log of who sent the Tweet, when and what was Tweeted.

Interesting take on things - I was simply trying to get the module working as it stood (apologies for leaving out the schema for that table).

I will try to reroll a patch as soon as I can, that includes an update hook for the new table.

@65: I would be interested in seeing how you have this working. Are you using the "Scheduler" module to publish the nodes? That is the issue I am attempting to resolve.

torgosPizza - When I have the code into production on my site, I'll get the code cleaned up so I can show it to you.

Basically, I use the Twitter module only for the code to send the tweet. I have written a helper module to use CCK fields for the tweet content and when the node is updated using hook_nodeapi(), I send the tweet.

So I am not using the "fields" the Twitter module adds when the node is created.

Subscribing

i have implemented hook_scheduler_api in twitter_post module and add a table in db.

function twitter_post_scheduler_api($node, $action){
  if ($action == "publish"){
        
    module_load_include('inc', 'twitter');
    $post = twitter_get_post( $node->nid ); 
    
    if ( !empty($post) ) {
      
      $twitter_account = twitter_account_load($post['twitter_account']);
      
      $replacements = array('!title' => $node->title,
                          '!url' => url('node/'. $node->nid, array('absolute' => TRUE, 'alias' => TRUE)),
                          '!url-alias' => url('node/'. $node->nid, array('absolute' => TRUE)),
                          '!user' => $node->name);
    
      if (strstr($post['twitter_status'], '!tinyurl') !== FALSE) {
        $replacements['!tinyurl'] = twitter_shorten_url(url('node/'. $node->nid, array('absolute' => TRUE)));
      }
      
      $status = strtr($post['twitter_status'], $replacements);
      
      try {
        $result = twitter_set_status($twitter_account, $status);
  
        drupal_set_message(t('Successfully posted to Twitter'));
      }
      catch (TwitterException $e) {
        drupal_set_message(t('An error occurred when posting to twitter: %code %error',
        array('%code' => $result->code, '%error' => $result->error)), 'warning');
      }
    }
  }
}

version 6.4

New features have to be implemented first in the Drupal 7 version and then ported back.

Please submit a 7.x-3.x version. Otherwise I will find some time to port this to Drupal 7 but it will take more time.

Changed issue version to 7.x-3.x.

Has anybody managed to port dmouse's patch (#70) to drupal 7?

Moving to 7.x-5.x and setting as 'needs work'.

There is already enough code in this module. I think it would make sense to write this as another contributed module.

Is the 5.x dev version still worked on or should we change this to the 6.x dev version?

Is this still being worked on for 7.x-5.8 ?

Subscribing

Subscribing news for the D7 realease?

Here is my shot with a module, twitter_post_scheduler.

It depends on scheduler and twitter_post modules. It does not alter any code in twitter module. I built it based on 7.x-5.8 version.

The scheduled tweets are saved in cache table. I only considered site wide account use for my use case. Cache table will remember only one entry per node. If you enter tweets multiple times for a node, only the last entry will be remembered.

Please provide a patch instead of a zip file so it can be easily reviewed by the community.

You can find instructions at https://drupal.org/project/twitter/git-instructions.

I am looking to add this feature also. I am using rules scheduler (submodule of rules) and an action set component to accomplish this.

I have tested:

1. Regular Rule with action "post to twitter" (immediately on node creation) - WORKS PERFECT

2. Use Rules Scheduler with action set component and action "post to twitter" - NOT WORKING

3. Use Rules Scheduler with action set component and action "post to facebook" (using facebook rules module) - WORKS PERFECT

NOTE: I only mention facebook because I have ensured the rules scheduler is triggering correctly (I use elysia cron to trigger the action component for both twitter and facebook on node creation with a short offset time). I do see both actions move to the schedule queue. They both run when elysia cron triggers and facebook posts to users wall, but twitter does not.

This may sound obvious, but it seems related to the [current user] selection in the _twitter_actions_get_twitter_id function in twitter_actions.module? The Rule (Reaction Rule) passes the "site:current-user" data selector, but when the action set component uses [current user] it silently fails? Could we just use site:current-user directly to perform this validation in _twitter_actions_get_twitter_id function?

If there is any other help I can provide, I would be happy to do what I can!

Here is an export of the Rule itself, and then also Rule Component:

Rule (Reaction Rule):

{ "rules_twitter_post" : {
"LABEL" : "Twitter Post",
"PLUGIN" : "reaction rule",
"OWNER" : "rules",
"REQUIRES" : [ "rules", "rules_scheduler" ],
"ON" : { "node_insert--article" : { "bundle" : "article" } },
"DO" : [
{ "schedule" : {
"component" : "rules_trigger_twitter_post",
"date" : "+5 seconds",
"identifier" : "Post node [node:nid] on user [site:current-user] twitter feed",
"param_node" : [ "node" ],
"param_user" : [ "site:current-user" ]
}
}
]
}
}

Rule Component (Action Set):

{ "rules_trigger_twitter_post" : {
"LABEL" : "Trigger Twitter Post",
"PLUGIN" : "action set",
"OWNER" : "rules",
"REQUIRES" : [ "rules", "twitter_actions" ],
"USES VARIABLES" : {
"node" : { "label" : "node", "type" : "node" },
"user" : { "label" : "user", "type" : "user" }
},
"ACTION SET" : [
{ "rules_core_twitter_actions_set_status_action" : {
"message" : "[node:short-title] [node:url]",
"sender" : "[current user]"
}
}
]
}
}

EDIT: I am using D7 latest release. From above comments, it seems using the separate submodule for the scheduler is the answer for now.

I will do some testing for #78 and see if I can get things working for my situation.

Unfortunately, I already notice their might be a problem. Each individual user on the site can connect their Twitter account, so many accounts will exist. There will not be one single site wide Twitter account.

I don't think #78 will work for my case?

Added submodule in via git. Seems to work for me using latest stable of scheduler.

When node is saved, "Announce this post on Twitter" checkbock is not saved and stays unchecked.

OAuth 7.x-3.2
Scheduler 7.x-1.3
Twitter Post Scheduler 7.x-5.x

It may be beset if this functionality is left to the 7.x-6.x branch where the status messages are stored as a field..