height of masthead not respected with custom image [#440212]

If a custom masthead image is selected and the header height is specified, the image is used, but the height of the header is not used.
The bug can be easily fixed adding:

  <?php if (theme_get_setting('mastheadfixedfluid') ) {

height: print theme_get_setting('mastheadfixedfluid') px;
<? } ?>
?>

after line 143 on page.tpl.php:

  background-image:url('/<?php print theme_get_setting('masthead_bg_path') ?>');

Comments

Comment #1

FiNeX CreditAttribution: FiNeX commented 21 April 2009 at 11:31

I'm sorry, the pasted code is not displayed correctly with the "php" delimiter. The following is the right bug report:

If a custom masthead image is selected and the header height is specified, the image is used, but the height of the header is not used.
The bug can be easily fixed adding:

  <?php if (theme_get_setting('mastheadfixedfluid') ) { ?>
    height:<?php print theme_get_setting('mastheadfixedfluid') ?>px;
  <? } ?>

after line 143 on page.tpl.php:

  background-image:url('/<?php print theme_get_setting('masthead_bg_path') ?>');

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 21 April 2009 at 23:27

Hi,

Thank you for the correction, I can confirm that it works.

Question:
I do not know PHP but I saw the following code and removed it from the page.tpl.php and it seemed to remove the text from overlapping the masthead. Would this modification affect other code elsewhere?

 <?php if ($site_name): ?>
          <h1 class='site-name'> <a href="<?php print $base_path ?>" title="<?php print t('Home'); ?>"> <?php print $site_name; ?> </a> </h1>
        <?php endif; ?>

Thanks