Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

Status: Active » Needs review
FileSize
3.04 KB

out of date. here's a re-roll.

drewish’s picture

forgot to mention that it needs and update function for the schema changes.

benklocek’s picture

Any chance that this will get committed?

David Lesieur’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
FileSize
3.08 KB

Here's an updated patch for the D7 version. The update function is provided and the interface text is improved (I think).

sw3b’s picture

Status: Needs review » Reviewed & tested by the community

Good work on the patch for D7... Merci @David pour le bon travail !!! ;o)

David Lesieur’s picture

Status: Reviewed & tested by the community » Needs work

I have noticed that error messages get thrown when $nav['full_list'] is empty. For example, this happens when the custom pager is based on a view that returns no results. The patch will need a little work to add more validation.

David Lesieur’s picture

Status: Needs work » Needs review
FileSize
3.13 KB

Here's a new patch that fixes the error messages.

David Lesieur’s picture

Actually this patch is better. It also avoids wrapping when the list being paged on has a single item.

sw3b’s picture

Status: Needs review » Reviewed & tested by the community

Work for me thanks !