All of my blocks disapear when I switch to the goofy theme; including my navigation block. I can find no way to get the blocks back.

If I go to configure the goofy theme, I get this error:
>
Fatal error: Call to undefined function form_checkbox() in /opt/lampp/htdocs/drupal-4.7.0-beta3/themes/engines/goofy/goofy.theme on line 9
<

My environment:

Debian 3.1 unstable
Drupal 4.7.0-beta3
Xampp w/PHP5.1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TDobes’s picture

The goofy theme is not yet available for Drupal 4.7.

TDobes’s picture

Assigned: Unassigned » TDobes
Priority: Critical » Normal
Status: Active » Fixed

The goofy theme is now available for Drupal 4.7.0beta5 and newer.

chrisd’s picture

Version: 4.6.x-1.x-dev » 4.7.x-1.x-dev
Status: Fixed » Active

I get a similar error running: v 1.22 2006/03/05 on Beta6

Fatal error: Call to undefined function: form_checkbox() in E:\DomZeus\getdialupcom2017\wwwroot\themes\goofy\goofy.theme on line 16

Thanks,
Christophe D

Heine’s picture

Title: Goofy theme broken in 4.7? » Goofy theme contains 4.6 code (form_checkbox)

goofy_settings contains a call to form_checkbox, which leads to the error described in #2 and form_textfield; both 4.6 form functions. If I have time later today, I'll update this to 4.7 forms api. (But don't hold back on the patches).

Marked http://drupal.org/node/54137 a duplicate

Heine’s picture

I'm done, but I ran into an issue with theme_get_setting, using $theme_key to get settings. Though a workaround is easy, I'll won't attach a patch until I've sorted out the theme_get_setting issue.

Heine’s picture

Status: Active » Needs review
FileSize
5.95 KB

Thanks to chx, the problem is solved: thou shallt not call theme_get_settings! Use theme('get_settings', 'the_setting_to_retrieve').

I've converted goofy_settings to forms api, added a file upload for the secondary logo, clobbered all remaining theme_get_settings and an occasional variable_get.

One of the more outrageous things I've done is to change 'Use default secondary logo' to 'Use a secondary logo'. The default logo will be used if the textfield Path to custom secondary logo is empty.

Note: theme('get_settings') doesn't have the 'default' facility of variable_get, but returns NULL if a variable doesn't exist.

(patch is from the goofy directory)

Heine’s picture

that should be get_setting (no s) in the post above.

Heine’s picture

I'm flooding this issue a bit, but there's still a problem with theme specific settings when Goofy is not the active theme. I'll look into that later.

Heine’s picture

FileSize
6.12 KB

Similar to the above patch but removed all theme('get_setting') code from goofy_settings. Called theme_get_settings('goofy') instead. This fixes the problem when another theme is active during goofy configuration.

boelkstoff’s picture

hello.
I really like your theme.

Could you please (when you have time) make it work with 4.7RC1.I
I just did a new installation and it seems not to work.

Fatal error: Call to undefined function: theme_onload_attribute() in /home/www/web2_103/html/zps/drupal/themes/goofy/goofy.theme on line 43

Heine’s picture

@previous poster; this thread concerns updating goofy to 4.7

boelkstoff’s picture

hello.
I just downloaded your latest version for drupal 4.7RC1.
When I active your awesome theme and click on configure I get the following error message:
Fatal error: Call to undefined function: form_checkbox() in /home/www/web2_103/html/zps/drupal/themes/goofy/goofy.theme on line 16

Heine’s picture

@previous poster. Please test the patch.

jase951’s picture

http://drupal.org/files/issues/goofy_forms_api_0.patch

patch seems to work with drupal-4.7.0-rc2.

KenMasters’s picture

Assigned: TDobes » KenMasters
Category: bug » support
FileSize
14.31 KB

attach patch in goofy.theme, for drupal 4.7 ;-)

Heine’s picture

I'll make a new one later, clearly seperating new functionality (logo upload) and bugfix.

Alauddin’s picture

Hi,

I just installed the patch and it seems to work fine. My question now is in 'blocks' section I have only
left sidebar and right side bar....

NO - Content option?

How can I get blocks to display in the content area?
Sorry if its an obvious question but not able to figure out.

Thanks
Al

Heine’s picture

Sorry, there's no content region for blocks in goofy atm

peddecke’s picture

The patch works good here, but why isn't the new theme delivered with the theme as listed on "themes for 4.7.x"?

ton_cut345’s picture

How to open the goofy.theme? i've tried double clicking it and i goes to windows themes. i've tried open with option still i can't open it. anyone help?..

pixor’s picture

Where do I find the patch? I've looked in CVS at head, but it's obviously not the right place. I'd like to use the patch to fix the Fatal error: Call to undefined function: form_checkbox() problem.

Thanks.

pixor’s picture

OK, silly me, I see the patch now. It's been a long day, honest!

Linulo’s picture

Old 4.6. version is still up for 4.7. theme download and the patch in this thread is still not submitted to CVS. Please fix.
Thank you.

walterbyrd’s picture

Secondary logo does not appear in all pages.

Also, I have modified the goofy theme to a blue color. I would be glad to contribute it, but none of the maintainers seem interested.

synet-consulting.com

Arthur2006’s picture

I would like to know how to get a blue color in the Goofy theme. I like green.

greetings

Arthur

Mark Theunissen’s picture

Thanks so much for that patched .theme file, saved my day!! :)

fgm’s picture

I removed the 4.6 code in the D6 version too, and fixed the theme for D6, but it seems that the patched 4.7 version in #15 includes an uploaded secondary logo, while my D6 version only includes the typed-in name for the logo. It would be nice to also include this upload facility in the D6 version (http://drupal.org/node/255645)

fgm’s picture

Version: 4.7.x-1.x-dev » 6.x-2.x-dev

There is no longer any 4.6 code in either 6.x version.

fgm’s picture

Status: Needs review » Fixed

Problem no longer applies in DRUPAL-6-2 branch: the settings code is now in theme-settings.php

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.