Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
On line 145 of ahah_helper.module the ahah_helper_render function tries to include the page file that was referenced in the menu entry.
This fails because the require_once call uses form_state['storage']['#ahah_helper']['#file'] instead of form_state['storage']['#ahah_helper']['file']
Current code
// $form_state['storage']['#ahah_helper']['file'] has been set, to know
// which file should be loaded. This is necessary because we'll use the form
// definition itself rather than the cached $form.
if (isset($form_state['storage']['#ahah_helper']['file'])) {
require_once($form_state['storage']['#ahah_helper']['#file']);
}
Should be
// $form_state['storage']['#ahah_helper']['file'] has been set, to know
// which file should be loaded. This is necessary because we'll use the form
// definition itself rather than the cached $form.
if (isset($form_state['storage']['#ahah_helper']['file'])) {
require_once($form_state['storage']['#ahah_helper']['file']);
}
Comment | File | Size | Author |
---|---|---|---|
#1 | ahah_helper-480472.patch | 780 bytes | svendecabooter |
Comments
Comment #1
svendecabooterI encountered the same problem.
Attached a patch that fixes this.
Comment #2
Rok Žlender CreditAttribution: Rok Žlender commentedPatch works fine for me.
Comment #3
chaps2 CreditAttribution: chaps2 commentedPatch works for me too.
Comment #4
jefkin CreditAttribution: jefkin commentedI discovered this on my own, repaired as the patch does, and was about to report it when I found this! ... so patch works. More than 3 months now. push this one through!
Comment #5
pounardI have some error message with 2.0 version, I would have done something like this:
In some cases, it seems that the 'file' key is defined, but data is empty (I'm unable to know why).
Comment #6
hadsie CreditAttribution: hadsie commentedthis patch works for me as well.
Comment #7
lslinnet CreditAttribution: lslinnet commentedworked fine for me as well
Comment #8
pounard@Wim Leers (or any other module's maintainer)
I have some large pieces of code in modules that'll get on d.o based on this module. Could you commit the #1 patch to 1.x branch and make a new maintenance release please?
I can't let the ahah_helper module patching instructions in my readme file, that's so ugly.
Comment #9
Cristhian CreditAttribution: Cristhian commentedreleased branch 2.x-dev branch, patch commited there
Comment #10
pounard@Cristhian #9 Does the #1 patch will be commited to 1.x branch?
Comment #12
pounardWhat about this issue, when is it going to be released? Could you make a bugfix release for this please? It would avoid that hundreds of site mainteners have to patch the module at each site install.