This is a child task for #422380: Convert all core module to use new static caching API focusing on the trigger module.

CommentFileSizeAuthor
#10 481506-10.patch1.86 KBJamesAn
#8 481506-8.patch1.56 KBJamesAn
#3 481506-3.patch1.56 KBJamesAn
#1 481506-1.patch1.54 KBJamesAn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JamesAn’s picture

JamesAn CreditAttribution: JamesAn commented
Status: Active » Needs review
FileSize
481506-1.patch1.54 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn CreditAttribution: JamesAn commented
Status: Needs work » Needs review
FileSize
481506-3.patch1.56 KB
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

This one's RTBC as well (assuming the other two rtbc patches like this with code style questions on multiple statics per function get committed as is, otherwise it's CNW).

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Reviewed & tested by the community

re-test.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn CreditAttribution: JamesAn commented
Status: Needs work » Needs review
FileSize
481506-8.patch1.56 KB

Rerolled.

Status: Needs review » Needs work

The last submitted patch failed testing.

JamesAn’s picture

JamesAn CreditAttribution: JamesAn commented
Status: Needs work » Needs review
FileSize
481506-10.patch1.86 KB

Rerolled.

cburschka’s picture

cburschka
they
CreditAttribution: cburschka commented
Status: Needs review » Needs work 
+++ modules/trigger/trigger.module	28 Oct 2009 06:29:07 -0000
@@ -594,7 +594,7 @@ function trigger_actions_delete($aid) {
-  static $triggers = NULL;
+  $triggers = &drupal_static(__FUNCTION__);
   if( $triggers ) {

I think you can fix that if-clause down there in passing without endangering a kitten.

It's supposed to be "if ($triggers)", of course.

This review is powered by Dreditor.

Pasqualle’s picture

Pasqualle
Location 🇭🇺 Budapest
CreditAttribution: Pasqualle commented
Status: Needs work » Needs review

#10: 481506-10.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 481506-10.patch, failed testing.