CDATA is pointless [#494848]

This module uses CDATA for all tags' values. In fact, they are completely unnecessary except for highly unusual circumstances. Please see http://en.wikipedia.org/wiki/CDATA#CDATA_sections_in_XML for an explanation.

Comment	File	Size	Author
#6	6.x-1.1_add_cdata_wrapper_support.patch	2.46 KB	agalitsyn
#3	no_cdata.patch	936 bytes	Aren Cambre
#1	no_cdata.patch	892 bytes	Aren Cambre

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Aren Cambre CreditAttribution: Aren Cambre commented 18 June 2009 at 02:54

Status:

Active

» Needs review

File	Size
no_cdata.patch	892 bytes

Patch attached.

Comment #2

Aren Cambre CreditAttribution: Aren Cambre commented 18 June 2009 at 02:56

This also appears to fix #494846: XML export pads all values with spaces. I don't know why!

Comment #3

Aren Cambre CreditAttribution: Aren Cambre commented 18 June 2009 at 04:29

File	Size
no_cdata.patch	936 bytes

Mistake in original patch caused incorrect entity references. Fixed version attached.

Comment #4

neclimdul

He/Him

CreditAttribution: neclimdul commented 24 June 2009 at 17:30

Status:

Needs review

» Fixed

Committed a modified version of this with the logic in the preprocess function. Thanks.

Comment #5

8 July 2009 at 17:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #6

agalitsyn CreditAttribution: agalitsyn commented 6 December 2012 at 07:16

Version:	6.x-1.0-beta2	» 6.x-1.1
Status:	Closed (fixed)	» Needs review

File	Size
6.x-1.1_add_cdata_wrapper_support.patch	2.46 KB

CDATA can be needed for specific fields.

So I use a standart field option called "Element wrapper type" to add CDATA wrapper. Views have variable "views_field_rewrite_elements" which can be overriden with yours additional wrappers.

I add cdata using drush

drush eval "variable_set('views_field_rewrite_elements', array('' => t('- Use default -'), '0' => t('- None -'), 'div' => t('DIV'), 'span' => t('SPAN'), 'h1' => t('H1'), 'h2' => t('H2'), 'h3' => t('H3'), 'h4' => t('H4'), 'h5' => t('H5'), 'h6' => t('H6'), 'p' => t('P'), 'strong' => t('STRONG'), 'em' => t('EM'), 'cdata' => t('CDATA')));"

And write come code to support this wrapper. (see patch)