After upgrading to Views 2.6, several of my views started displaying differently, because they found templates files matching their "view tag" (templates that I wasn't intending them to use!) See #354270: Allow Views Templates to Affect Views Output by Tag
Can you please document this new behavior?
In particular, the help text when entering a view tag says: "Enter an optional tag for this view; it is used only to help sort views on the administrative page." That's simply not true any more.
Maybe it should say something like "... it is used to help sort views on the administrative page and in selecting a template file for displaying this view."
Comment | File | Size | Author |
---|---|---|---|
#7 | views-508832.patch | 2.17 KB | Nick_vh |
#5 | views-508832.patch | 2.06 KB | Nick_vh |
Comments
Comment #1
dawehnerOk i think this is not real a bug report. It does not "broke" anything.
Be free to post a patch
Comment #2
dawehnerAdd tag
Comment #3
Nick_vhThis gave me a headache and this is not wanted behaviour. I tagged a view as page and suddenly the theme selection did strange things. I dived deep in to the code in order to find this bug and after 3 hours I managed to find where the problem arised.
Please remove this behaviour since I do not think this is wanted behaviour, if so please update the documentation in the view tag description.
Ps : If wanted I upload a patch that removes this line in theme.inc to allow tags to be a path for the theming.
Comment #4
dawehnerYou shouldn't remove existing features, because this might break it for many more people.
Comment #5
Nick_vhThen we should rewrite the documentation of the tag functionality. Included is a patch that can help. I do not really know the workflow around here so correct me if I'm making mistakes
Comment #6
dawehnerI would call it: Tags are also added to your template suggestions, so take care what you set here.
Comment #7
Nick_vhUpdated
"Tags are also added to your template suggestions, so take care what you set here. For example setting the tag Page will give all your views the Page template."
Comment #8
esmerel CreditAttribution: esmerel commentedComment #9
Nick_vhPlease commit this so it can be closed,
thanks
Comment #10
dawehnerPlease don't push issues like this. The views issue is already crowded enough :((((((
Comment #11
merlinofchaos CreditAttribution: merlinofchaos commentedHey Nick:
I maintain two giant packages. Sometimes it takes me weeks or months to get to these issues. There is little value to bumping the issues. They won't magically get me more time or change when I can get to it. If an issue is RTBC then all that can be done is to wait.
Committed to all branches.
Comment #12
Nick_vhI know that and I wanted to apologize but that would bump the issue again ;-)
Thanks for everything, really