This patch allows you to provide an #attributes array in your #options of a tableselect type to do things like add classes to rows, etc.

Example:

$options[$name]['title'] = "my option"
    $options[$name]['type'] = "something else"
    $options[$name]['#attributes'] = array ('class' => 'super duper');
CommentFileSizeAuthor
#4 tableselect_row_attributes.diff1.96 KBJacobSingh
tableselect_row_attributes.diff1.47 KBJacobSingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JacobSingh’s picture

JacobSingh CreditAttribution: JacobSingh commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs work » Needs review

This patch looks simple, but I'd like to see us extend the PHPdoc a bit to explain why you might care about passing in an '#attributes' array. Should be RTBC with more extensive documentation.

JacobSingh’s picture

JacobSingh CreditAttribution: JacobSingh commented
FileSize
tableselect_row_attributes.diff1.96 KB

I think those are E_NOTICE exceptions... this should fix them.

Also, added an example and some docs. Real docs should actually go on the form api reference page though.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

Looks good, just needs tests to pass and that documentation.

JacobSingh’s picture

JacobSingh CreditAttribution: JacobSingh commented
Status: Needs work » Needs review

Setting to needs review... does the bot run on needs work?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Category: feature » task

whoops, cross-posted, and no it doesn't.

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

Mr. Bot?

JacobSingh’s picture

JacobSingh CreditAttribution: JacobSingh commented

What is up with the Bot?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

Looks good. Let's get this functionality in. :)

(And I'm not a Bot!) :P

tic2000’s picture

tic2000 CreditAttribution: tic2000 commented
Status: Reviewed & tested by the community » Needs review

Since you are not a bot ;)

Dries’s picture

Dries CreditAttribution: Dries commented

If someone runs the tests locally, that is good enough too. Not sure Joshua did.

Dries’s picture

Dries CreditAttribution: Dries commented

Testing was OK, see http://testing.drupal.org/pifr/file/1/tableselect_row_attributes_1.diff (thanks DamZ) but somehow not reported on d.o.

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to CVS HEAD. Thanks!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.