Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As the title say, when using ImageCache linked to node in the CCK fields display, the url used is a relative one in the RSS.
This causes a broken link from any images displayed in the RSS feed.
Comment | File | Size | Author |
---|---|---|---|
#11 | imagecache.512486.patch | 3.03 KB | aitala |
#7 | imagecache.512486.patch | 2.96 KB | mfb |
#5 | imagecache.512486-5.patch | 3.03 KB | ekes |
#3 | imagecache.512486-3.patch | 2.96 KB | ekes |
Comments
Comment #1
Canadaka CreditAttribution: Canadaka commentedI also just noticed this problem, surely this must be a common problem with a solution?
Comment #2
ao2 CreditAttribution: ao2 commentedHi, this also leads to this message from http://feedvalidator.org/
At first I didn't realize it was related to the "linked node" property, this is a useful hint, thanks.
Regards,
Antonio
Comment #3
ekes CreditAttribution: ekes commentedImagecache uses an absolute URL for the image path, I think this avoids problems like language prefixes. It uses relative links to node, which is usually good, but not within RSS as it doesn't have a concept of base URL. The theme function doesn't know that this is being formatted for a body/teaser to be used in an RSS context.
To maintain present functionality, and add a link that will work in RSS, the attached patch adds a "@preset image linked to node (for rss)" formatter that can be selected for the RSS display of the field should the administrator wish.
Comment #4
mfbNice, one problem with this patch, however.
Due to this line in theme_imagecache_formatter_linked():
the $presetname has "_linked" appended which is incorrect.
Comment #5
ekes CreditAttribution: ekes commentedUpdated to correct the #formatter when the parent preset theme function is called.
Comment #6
mfbAnother very minor issue, Drupal usually uses all caps for acronyms in the UI, so it should be RSS instead of rss.
Comment #7
mfbrerolled #5, only change is "RSS" instead of "rss".
Comment #8
neelan CreditAttribution: neelan commentedi used your #7 patch and enabled the display fields -> rss > thumbnail linked to node(for rss)
After that i checked in the rss code. but the image is not appearing. only the title is there in the rss xml.
(In the same time other imagecache preset also not appearing in the rss xml. while i used the old module file, the image appears in the rss)
Please help me to solve this issue. Please send me the entire module package to me for checking.
Comment #9
fizk CreditAttribution: fizk commentedMarking as ImageCache 3.x Todo.
Comment #10
fizk CreditAttribution: fizk commentedMarking as ImageCache 2.x Todo.
Comment #11
aitala CreditAttribution: aitala commentedThe patch reroll in #7 was not done on patch #5 but on patch #3 i.e. it undid the fix which would have prevented the issue listed in #8
Here is a corrected patch.