If I write an advanced help file with the following syntax:

<a href="&base_url&node/123/edit">Edit some content</a>

... and then place that on a site with Clean URLs disabled, I'll get a 404.

I believe this is due to line 559 in 6.x-1.2, which replaces &base_url& with $base_path, rather than calling url() on the node/123/edit part. Perhaps I'm misreading the documentation for generating links to other parts of the Drupal site?

CommentFileSizeAuthor
#3 521122-unclean_urls-1.patch973 bytesredndahead
#1 unclean_urls.patch995 bytesfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Status: Active » Needs review
FileSize
unclean_urls.patch995 bytes

Confirmed.

Suggested patch attached.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm commented
Title: &base_url&some/path doesn't work with clean URLs » &base_url&some/path doesn't work without clean URLs

topic error

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Status: Needs review » Fixed
FileSize
521122-unclean_urls-1.patch973 bytes

Here is an updated patch that just removes the extra line. This has been committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.