First this will fix the bugs: in #405234: Wrong function name called and missing argument.
Second: I don't like to extend the node-form, I rather prefer to extend the functionality of menu module ... at least from the users point of view. For me it seems to be more intuitive to do the menu-stuff in just one place.
Therefor I extended the node-form > "menu settings"-field-group:
The menu item will be also deleted if you delete the "Menu link title". If the "Menu link title" is left/set to blank and the "Parent item" was selected then the current node will be added to the "node trail". This means the current node behaves like a child of the parent item. If the node will be shown then the breadcrumb and the menu trail will set as expected.
The module weight is now set in nodetrail.install (there seems to be no update-funtion necessary, because the weight was already set in the hook_enable)
I've also created a README.txt It would be nice if you also can update the module Page, because it's a very useful module, but it was hard to find (maybe thats why it has such few users).
You can find all that stuff in the patch file: nodetrail.menu_settings.patch
Last point: I guess you are very busy ... at least you weren't be able to answer/fix the two pending issues. I don't want to see this module dying (I prefer to see this functionality in core ;) ). Thats why I offer you to take over maintaining this module (it will be my first one, so I'll find time in busy days). What do you think?
Comment | File | Size | Author |
---|---|---|---|
#6 | nodetrail.zip | 9.57 KB | marrch_caat |
#3 | nodetrail-feature.patch | 8.31 KB | osopolar |
#1 | nodetrail.menu_settings.patch | 8.77 KB | osopolar |
Comments
Comment #1
osopolarwondering that nobody answers ... I forgot the patch.
Comment #2
davyvdb CreditAttribution: davyvdb commentedThanks for the patch? But can you split this up in multiple issues with one feature/bug per issue? This will make this more transparent.
Comment #3
osopolarAs I can see you have already fixed the two issues so here comes the feature request only (see above description).
Comment #4
fuerst CreditAttribution: fuerst commentedThe patch works as advertised.
Comment #5
marrch_caat CreditAttribution: marrch_caat commentedDavy, thanks a lot for this so-much-needed module, simple and efficient, and Davy, thank you for making this module even better! I'm really surprised no one did that before you two. THANK YOU, GUYS!
Comment #6
marrch_caat CreditAttribution: marrch_caat commentedThe module with the provided patch (from comment #3) merged in works fine, with one small but terrible exception. If I open node add/edit page, select a parent menu item but leave menu link title field blank, and press "Preview" button - then parent menu item is cleared. Is there any way to fix that behavior? I attach the merged module files here for the case you'd like to check if the patch was applied properly. Please, help me!!
Comment #7
osopolarI want to bring this up again for usability reasons, because imho it's better to have one single point of change than two different fieldsets.
We should also think about #545052: Allow to assign content to a certain menu trail without menu link (a.k.a. Node Trails in core)