HS stores:
- the parameters passed to a form definition function
- the names of the form items, to know which part to render
- the path of the file in which the form definition function lives

All of this could be passed via Drupal.settings and then POSTed each time. This removes the need for a cache on the server side that cannot be reliably emptied. (But then, of course, Forms API's form cache is not emptied reliably either.)

Comments

Wim Leers’s picture

This will strongly affect hierarchical_select_after_build() and _hierarchical_select_submit().

Wim Leers’s picture

And it will remove the need to run _hierarchical_select_form_has_hierarchical_select(), which severely affected performance in some situations: #376159: _hierarchical_select_form_has_hierarchical_select() is expensive (and called from hook_form_alter()).

Wim Leers’s picture

Title: Remove Hierarchical Select's form cache » Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore

I'm not entirely sure anymore why I chose to reconstruct the entire form before rendering just the necessary HS form item. This is what makes HS slow on some node forms, because the node form itself is slow to reconstruct. Removing the need to reconstruct the entire form can speed things up *tremendously*.

Wim Leers’s picture

Title: Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore » Performance: Remove Hierarchical Select's form cache and don't reconstruct the entire form anymore
Wim Leers’s picture

Issue tags: +Performance
Wim Leers’s picture

This is a performance feature.

Wim Leers’s picture

Status: Active » Postponed

And will not be for HS 3.0 for D6.

Flying Drupalist’s picture

Hi, does this mean it'll be for D6 4.x or it won't be for D6 at all?

Wim Leers’s picture

For D6. More like 3.5. 4.0 will involve API changes.

3.1, 3.2: minor bugfix releases. This is just an optimization and will not change anything visibly.

Interested in writing this? Basically it will require either POSTing all required data or passing most or all of it via a GET request (i.e. via the Drupal path). Not sure if that will be sufficient though. We also have to keep the security implications in mind. If you want to do it, I'll outline what exactly you have to do. Should not be too hard.

digi24’s picture

subscribe

I made some measurements, and on my site the ajax call takes approx. 0.8 seconds and consumes a similiar ammount of memory like a regular page with views.

robby.smith’s picture

subscribing - +1 for performance upgrades =)

crea’s picture

Subscribing

inforeto’s picture

Subscribing

timl’s picture

subscribing
following from memcache + HS issue: http://drupal.org/node/538022

nirad’s picture

subscribing.

gianfrasoft’s picture

subscribing

morbiD’s picture

neochief’s picture

Subscribing.

Wim Leers’s picture

Issue tags: +HS4

Tagging for HS4. Included in the HS4 roadmap: http://drupal.org/node/1052670.

klonos’s picture

Version: 6.x-3.x-dev » 7.x-3.x-dev

This will happen in the 7.x branch.