The original pager implementation was scrapped from the Seven theme issue (#484860: Initial D7UX admin theme) because it requires another core patch applied, namely #514914: Re-add removed feature of $limit "passing" for themers, and that dependency was uncomfortable for that issue as far as I've understood. Now, we should fix this issue, since the current pager looks less informative, so here is a follow up with the pager.

Pager looks in Seven before this patch:

After this patch:

Still requires #514914: Re-add removed feature of $limit "passing" for themers which should be committed first or this patch is totally broken.

Files: 
CommentFileSizeAuthor
#21 538788_pager_with_select_nav.png7.02 KBsivaji
#21 538788_seven_pager_21.patch5.64 KBsivaji
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 538788_seven_pager_21.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#19 538788_reroll.png2.54 KBsivaji
#19 538788_pager_last.png3.54 KBsivaji
#19 538788_pager_intermediate.png4.05 KBsivaji
#19 538788_pager_first.png3.49 KBsivaji
#17 538788_seven_pager_17.patch4.15 KBsivaji
PASSED: [[SimpleTest]]: [MySQL] 19,199 pass(es).
[ View ]
#10 pagers.patch3.34 KByoroy
PASSED: [[SimpleTest]]: [MySQL] 10 pass(es).
[ View ]
#9 float-vs-text-align.jpg163.54 KBmr.baileys
#7 seven-pager-reroll.patch3.33 KBGábor Hojtsy
Failed: 13634 passes, 34 fails, 10 exceptions
[ View ]
#7 SevenPager.png42.47 KBGábor Hojtsy
#4 seven-pager.patch3.33 KBGábor Hojtsy
Failed: Failed to run tests.
[ View ]
#4 Pager.png27.33 KBGábor Hojtsy
PagerAfter.png19.67 KBGábor Hojtsy
PagerBefore.png18.16 KBGábor Hojtsy
seven-pager.patch3 KBGábor Hojtsy
Failed: 13641 passes, 7 fails, 0 exceptions
[ View ]

Comments

Status:Needs review» Reviewed & tested by the community

Works for me. Not sure if there's supposed to be any discussion over this new pager's functionality, but if this is the design then why not go for it? Sorry, still a Drupal issue tracker newb, but is it ok to RTBC like this?

Status:Reviewed & tested by the community» Needs work

I may have spoke too soon. I noticed a pager saying "1 - 0 of 19" on the taxonomy page when I was adding terms to a vocabulary. Without this patch, the normal pager isn't displayed at all. See image:

Interesting, since the issue being committed at #514914: Re-add removed feature of $limit "passing" for themers should have made this work. Hum. Are you sure you work with an up to date Drupal 7 checkout?

Status:Needs work» Needs review
StatusFileSize
new27.33 KB
new3.33 KB
Failed: Failed to run tests.
[ View ]

I've reapplied this patch to my testing environment and it still works as advertised above. Now that it does not have any dependencies. It would be great to verify this independently, but I still see this working. In the watchdog reports table:

Patch rerolled because it had some fuzz applying.

Status:Needs review» Needs work

The last submitted patch failed testing.

I'll try it again after I restore my D7 dev site... something broke it last night. : P

fwiw, I had just checked out D7 yesterday from HEAD when I saw that problem on a taxonomy term list page.

Status:Needs work» Needs review
StatusFileSize
new42.47 KB
new3.33 KB
Failed: 13634 passes, 34 fails, 10 exceptions
[ View ]

Here is a fresh reroll of the patch. Tested again, and it still works for me. Anyone else to verify?

Havent' looked at it in IE, but FF and Safari looking dandy.

StatusFileSize
new163.54 KB

Tested in IE 7 (some other items on the page are screwy, but both before and after patch), FF 3.5 and Safari 3 and the pager looks (and works) great, definitely an improvement. I was unable to reproduce the problem described in #2 and the pager worked consistently and had the correct numbers.

My only concern so far is

+.short-pager {
+  float: right;
+  margin-top: 2em;
+}

I've always been told that floats should have an explicit width (although it seems the sentence "a floated box must have an explicit width" has recently been removed from the CSS2.1 specs). What is the reasoning behind using float:right instead of text-align:right? Not sure the positioning of the element following the pager is ideal when using floats (see screenshot).

StatusFileSize
new3.34 KB
PASSED: [[SimpleTest]]: [MySQL] 10 pass(es).
[ View ]

changed the float to a text-align

.

If we want to use this new pager, which looks nice we need to make it

- easier to jump forward and backward,
- to jump to a specific page and also
- to tell the exact number of remaining items instead of showing the paging value.

We must keep First and Last. Example:

«First ‹Previous 50 Showing 100 – 150 of 250 Next 50› Last»

In this example, the 100 in bold should be clickable to show a simple form field, aka edit in place where the user would type a number to jump to the record.

Paging through a long list can be easy or painful. Let's not make this patch painful. :-)

Also, in this example:

«First ‹Previous 50 Showing 100 – 150 of 156 Next 6› Last»

... the Next part should be intelligent enough to display 6 (156 - 150). Using the 50 items on a page value is wrong here. Make it intelligent.

Status:Needs review» Needs work

The last submitted patch failed testing.

@xmacinfo:

>the 100 in bold should be clickable to show a simple form field, aka edit in place where the user would type a number to jump to the record

You mean like this: Jump pager?

@mattyoung:

Yes. This Minimax page module expose the current page number in a field for easy jump. But if we want a nice styling and look à la Seven, we could hide the field and expose it only when clicking on the current page number.

For example, clicking on the current page (or range):

«First ‹Previous 50 Showing 100 – 150 of 156 Next 6› Last»

would become

«First ‹Previous 50 [ 100 ] of 156 Next 6› Last»

where [ 100 ] would be the exposed field that would serve as jump. And in this example value permitted would be from 1 to 156 since we know that the max known is 156.

Status:Needs work» Needs review

#10: pagers.patch queued for re-testing.

StatusFileSize
new4.15 KB
PASSED: [[SimpleTest]]: [MySQL] 19,199 pass(es).
[ View ]

+1 for this pager it looks much better. The above patch fails to display link to first and last page which is required for easy navigation and it no longer works because the theme_pager_link() function signature has been changed as a part of #572618: All theme functions should take a single argument to make preprocess sane and meaningful. Attached patch adds link to first and last page and changes to match signature.

Status:Needs review» Needs work

Please provide a screen capture.

Also, please add a jump box in the middle of the pager. Without a jump box, this sort pager, although more beautiful, is not usable. See my comment in #15.

StatusFileSize
new3.49 KB
new4.05 KB
new3.54 KB
new2.54 KB

I have attached screenshots with this comment, will re-roll a patch with jump box similar to 538788_reroll.png.

BTW : How do i add screenshot inline like #7 ?

Looks nice! Adding the jump box will make it ready to rock.

A small note, in the intermediate version of the screen capture, the

... showing 51 - 100 of 207 ...

uses a range (51 to 100), which is fine in itselft. However, when combined with a jumpbox, it becomes tricky, since we might not want to ask the user to input the value of both start and end range. We should instead ask only for the start of the range:

... showing [50] - 100 of 207 ...

What do you think?

Status:Needs work» Needs review
StatusFileSize
new5.64 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 538788_seven_pager_21.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new7.02 KB

Attached patch provides a way for quick navigation as mentioned in #18.

@xmacinfo, I am using list select instead of inputbox see the attached snapshot and patch. I know the patch needs work, i like to confirm that i am on right track here.

Status:Needs review» Needs work

The last submitted patch, 538788_seven_pager_21.patch, failed testing.

Version:8.x-dev» 7.x-dev

Indeed, select is the way to go for ranges. Much more clean. But I would include the whole range in the select input items:

« First « Prev 50 [400 - 450] of 1001 Next 50 » Last »

[400 - 450] => the displayed range in an item in the select list...

I cannot review the rest of your patch or the TO DO! for new. :-)

Version:7.x-dev» 8.x-dev

I am going to push this feature to Drupal 8. Looking at the progress so far and considering that we are deep into UI freeze.

This feature has no clear usability win, although Mark Boulton did indeed design it this way and we are striving to implent it as such, there is no sign that we are actually improving anything. Sure with the latest patch I can navigate to page 77, but who knows whats on page 77?

Our current pager, although not the best looking one out there - has no known usability flaws, nor is its inability to jump to be found a huge problem.

Version:7.x-dev» 8.x-dev

sub

@Bojhan,

users know what's on Page 77.

eg. I filtered a list of articles and navigate to page 77. I would know my content is on page 77 now. when i go to other computer or next time to edit the article I will jump to page 77 directly.

Status:Needs work» Needs review

#21: 538788_seven_pager_21.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, 538788_seven_pager_21.patch, failed testing.

Issue tags:+mobile

Marking #1488866: Redesign pagers for administrative lists. as a dupe.

An improved pager would make things easier for mobile users as well, as long as the touch targets were large enough.

Hi all, you may want to take a look at the Pagerer module I recently contributed. http://drupal.org/project/pagerer

This is going to have to change when Views comes into D8 Core, right? Otherwise it's just a matter of getting someone to look at migrating the patch from #21 to the new /core structure.

@Bojhan, I'm assuming that this is both a usability improvement as well as just a matter of following the original design, right?

How do we get this moving so that Seven looks better than it did in D7?

Status:Needs work» Closed (duplicate)

I'm going to consider this an duplicate of #2016867: Pager Style Update. If anyone has any objections to the pager design found in the new Seven style guide we can take it up there.

Status:Closed (duplicate)» Needs work

The issue at #2016867: Pager Style Update is a complete regression that does not take into account any discussion taken here. Please do not sidetrack.

Ok, but I do think it's counter productive to have the two discussions completely separate. We can't commit both.

Ok, we've managed to figure out a good separation between issues. See my comment here:
https://drupal.org/node/2016867#comment-7572783

Keep up the good work!

So what is this issue still about?