The attached patch makes System independent from Node. It is split off from #375397: Make Node module optional.

CommentFileSizeAuthor
#8 node_decouple_system_08.patch19.07 KBXano
#6 node_decouple_system_07.patch19.29 KBXano
#4 node_decouple_system_05.patch19.51 KBXano
#2 node_decouple_system_04.patch16.68 KBXano
node_decouple_system_03.patch16.65 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
node_decouple_system_04.patch16.68 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
node_decouple_system_05.patch19.51 KB
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs review » Needs work 
+  db_query("DELETE FROM {variable} WHERE name LIKE 'node_%'");

That should be a db_delete() :)

+  variable_set('node_options_forum', array(0 => 'status'));

Hm.. I think that should actually be in forum.module ?

+      ->condition('link_title', array('Menu link #1-1', 'Menu link #2'), 'IN')

IN should be the default for an array, not necessary...

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
node_decouple_system_07.patch19.29 KB

Grepping for "node_options_forum" only shows system.install. You're right, but it I think we're safe to remove that variable altogether in another patch.

Status: Needs review » Needs work

The last submitted patch failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
node_decouple_system_08.patch19.07 KB

Fixed the bug and integrated the patch with #510782: Installer links to help module and other pages even when they are not available.

Status: Needs review » Needs work

The last submitted patch failed testing.

eaton’s picture

eaton CreditAttribution: eaton commented
joshmiller’s picture

joshmiller
he/him
Primary language English
Location Indianapolis, Indiana, USA
CreditAttribution: joshmiller commented
Version: 7.x-dev » 8.x-dev

Definitely a D8 idea...

chx’s picture

chx CreditAttribution: chx commented

http://buytaert.net/8-steps-for-drupal-8 let's stop saying smallcore.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Closed (works as designed)
Issue tags: -makenodeoptional

I believe this has been addressed in #375397: Make Node module optional.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned