I would love to use this module while developing my sites, but cannot due to the fact that I am using the private file system and CSS aggregation is disabled. Is it possible to make this work with private files? It would also solve my problems with the 30 stylesheet limit in IE.

I would like to stay away from the IE Unlimited CSS Loader module if possible (uses @import, I think).

CommentFileSizeAuthor
#4 ie_css_optimizer-6.x-1.0-547400_1.patch1.02 KBjm.federico
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arhak’s picture

arhak CreditAttribution: arhak commented

for those looking for workarounds for private download support:

according to issue 146611#comment-1182361 at #146611: Allow JS/CSS aggregation in private mode D7 is expected to ship with public/private by file functionality, so creating a new folder for D6 was denied

nevertheless, making a public folder available to support features unavailable for private download method is a very affordable cost

so I'll be maintaining such as a path for D6 at #181003: private download method and dynamically generated CSS and JS

Geekish’s picture

Geekish CreditAttribution: Geekish commented

Thanks arhak, your patch works perfectly and now I can finally optimize my CSS and JS properly under the private file system! I have been looking for a way around that problem for quite a while.

As for my original request to the maintainer of the IE CSS Optimizer module, I'm not sure if I should retract it or not. I still think it would be nice to be able to use it for development of sites using private download method. Unfortunately, even though with arhak's patch the option to partially optimize CSS appears valid, it is impossible to select it for use (as I would expect).

I'm going to leave it up to the maintainer to decide whether or not to close this feature request, as I am not a coder and don't know whether the request is feasible or not.

JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented

Hmm… so merlinofchaos mentions it might be possible to get this working with private download method.

It is possible. See ctools/includes/css.inc (and there's a hook_file_downloads in ctools.module that is needed)

I'll have to investigate when I have time. (Unless someone wants to write a patch! I love patches!)

jm.federico’s picture

jm.federico CreditAttribution: jm.federico commented
Title: Compatibility with private download method? » Compatibility with private download method
Version: 6.x-1.0-beta1 » 6.x-1.0
FileSize
ie_css_optimizer-6.x-1.0-547400_1.patch1.02 KB

If you apply patch in #572516: make private download method support css/js aggregation, color module and js translations #50, use this patch for compatibility with this module.

arhak’s picture

arhak CreditAttribution: arhak commented

@#4 good jm.federico, you got it
I didn't realize that this module would need a patch too, to be compatible with #572516-50: make private download method support css/js aggregation, color module and js translations
thanks for your contribution

izmeez’s picture

izmeez CreditAttribution: izmeez commented

subscribing

jm.federico’s picture

jm.federico CreditAttribution: jm.federico commented
Status: Active » Needs review
jbm’s picture

jbm CreditAttribution: jbm commented

huh, heu sorry but where can i find the patch and how do i apply the patch, im realy sorry but all the link realte to differents things (color stuff etc..)

arhak’s picture

arhak CreditAttribution: arhak commented

your answer is precisely at #4
the referenced patch brings private download capability to several features, and patch @#4 takes advantage of it, to make this module work

if you READ (not apply) the patch at #572516-34: make private download method support css/js aggregation, color module and js translations (which is for D6.15) you'll see it is split in 4 chunks
the first chunk ("private download -base- file API") is enough for patch @#4 to work properly,
the other 3 chunks are for "optimize CSS/JS", "JS translation", and "color module" respectively

regretfully the latest patch at that thread isn't split in such chunks, it is rather a whole patch