userreference : garbage display on user page [#54922]

the values returned by userreference_user hook are incorrectly formated, resulting in garbage output on user/'uid' and user/'uid'/edit pages.

The included patch corrects that
Note : it doesn't deal with the content of the 'referenced by' secondary tab on the user edit page, which is still empty for the moment ($op == 'form' not implemented)

Comment	File	Size	Author
#2	userreference.module_0.patch	1.29 KB	yched
	userreference.module.patch	1.49 KB	yched

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

yched CreditAttribution: yched commented 20 March 2006 at 14:49

Status:

Active

» Needs review

Comment #2

yched CreditAttribution: yched commented 20 March 2006 at 15:09

File	Size
userreference.module_0.patch	1.29 KB

Updated :
$field['field_name'] is not available in this part of the code - and maybe not relevant either ?

Comment #3

codexmas CreditAttribution: codexmas commented 20 March 2006 at 15:38

I described this issue in another comment:
http://drupal.org/node/53429

It is not really a bug because several of the CCK modules are under development.
Especially the userreference module, it is basically just a skeleton that hasn't been
fleshed out yet.

Comment #4

yched CreditAttribution: yched commented 21 March 2006 at 18:01

Agreed on the 'skeleton' thing.
Yet the _user hook generating the display on user profile pages is coded, it's just not outputting the results in the expected format.

So even if the code is subject to future changes, we might just as well put a coherent version in cvs..

Comment #5

JonBob CreditAttribution: JonBob commented 5 April 2006 at 21:02

This feature has been removed temporarily, but I'll leave this issue in patch status for when I have time to review the fix and reintroduce the feature. It needs to be done in a somewhat configurable fashion, I think; the presence of userreference should not enforce this display. Maybe it's not the domain of this module at all.