Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Some things I noticed while reviewing...
Comment | File | Size | Author |
---|---|---|---|
#8 | cleanup.patch | 4.96 KB | Bojhan |
#6 | drupal.text-summary.patch | 1.67 KB | sun |
#5 | cleanup.patch | 0 bytes | Bojhan |
#5 | cleanupmorefinished.png | 15.83 KB | Bojhan |
#4 | 553308_text_with_summary_cleanup_4.patch | 3.85 KB | sign |
Comments
Comment #1
yched CreditAttribution: yched commentedIt's not a preview, it's a widget to input the field's default value. All field types show this (except when they don't support default values).
My personal opinion is that it belongs to it's own, separate subform.
About the field being 'long': see #513414: User-Test Position of Teaser field above main text field in node form
Comment #2
yched CreditAttribution: yched commentedComment #3
Bojhan CreditAttribution: Bojhan commentedOk, started the cleanup - encountered some issues trying to get the new (Edit Summary) pattern to apply to here as well. Would also like to put Default value in a separate fieldset.
Comment #4
sign CreditAttribution: sign commented(Edit Summary) pattern applied
added a new div wrapper around textareas with class .text-textarea-with-summary-wrapper, didn't find any better way to do this, as we can't easily add a class to lets say #body-wrapper (field.form.inc line 152)
Comment #5
Bojhan CreditAttribution: Bojhan commentedA screenshot of sign his patch. Adjusted it a bit to put default values in its own fieldset to create more visual seperation.
Comment #6
sunCan you merge this patch into yours, please?
Please revert this - it's hard to translate "field" in this context.
I think we should revert this, too. I wanted to say
s/Help/Help text/
...but then figured that it's actually a description, so "Instructions" seems to be correct.
I'm on crack. Are you, too?
Comment #7
Bojhan CreditAttribution: Bojhan commentedSomehow, it turned out empty. I will look into it when I get home.
I do think "Required field" is far more descriptive then, required - then one would guess what required means in this context. I don't think we should avoid increasing the usability of this checkbox over translatability.
Instructions is better indeed, it was an attempt to make that whole help text area - better, but that seems like a hard thing to achieve.
Comment #8
Bojhan CreditAttribution: Bojhan commentedComment #9
Bojhan CreditAttribution: Bojhan commentedFor testing.
Comment #10
lisarex CreditAttribution: lisarex commentedLooks great. RTBC.
Comment #11
sunThis is not the fieldset.
A #weight of 0 doesn't need to be specified, it's the default.
This is no help text. Please revert to instructions.
Care to explain these changes?
Perhaps we should wait for the Field UI tests patch... ;)
I'm on crack. Are you, too?
Comment #12
MichaelCole CreditAttribution: MichaelCole commented#8: cleanup.patch queued for re-testing.
Comment #14
colanThe solution is to dump the entire concept. See #1378350: Clean up the "Long text and summary" field for details.