Line 137 reads:

list($menu_name, $parent_mlid) = split(':', variable_get("menu_block_{$delta}_parent", 'navigation:0'));

should read to avoid error:

list($menu_name, $parent_mlid) = preg_split('/:/', variable_get("menu_block_{$delta}_parent", 'navigation:0'));

Comments

guapolo’s picture

guapolo CreditAttribution: guapolo commented
Status: Patch (to be ported) » Needs review
apodran’s picture

apodran CreditAttribution: apodran commented

I suppose it would be better to use "explode" instead of "preg_split" in this case.
Because here are no regular expressions, "explode" will be faster choice.

So the line 137 will be:

<?php

list($menu_name, $parent_mlid) = explode(':', variable_get("menu_block_{$delta}_parent", 'navigation:0'));
?>
JohnAlbin’s picture

JohnAlbin
he/they/他
Primary language English
Location Taipei, Taiwan
CreditAttribution: JohnAlbin commented
Title: Deprecated error in menu_block.module line 137 (split() is deprecated in PHP 5.3) » split() is deprecated in PHP 5.3
Status: Needs review » Fixed

Thanks!

Fixed in -dev now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.