field_attach_preprocess() was (re-)introduced by #367595: Translatable fields, but currently only node module calls it.
Other fieldable entities (users, comments) should call it too. Taxo terms are a little off, because thet're not rendered through a template right now.

CommentFileSizeAuthor
#11 field_attach_preprocess-560608-11.patch1.72 KBplach
#9 field_attach_preprocess-560608-9.patch1.71 KBplach
#6 field_attach_preprocess.patch1.6 KByched
#4 560608.patch1.67 KBpounard
#3 560608.patch1.8 KBpounard
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Issue tags: +translatable fields

@yched:

I think at some point we discussed the fact that only nodes would hold translatable fields for now, to limitate UI work. Sorry if I'm on crack and that was dropped later on ?

Yes, that's true, although I'm trying to make the UI work with any fieldable entity. However without this themers needing to access the raw field values would still need to specify the langcode (FIELD_LANGUAGE_NONE), so this is needed. Not critical, though.

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Assigned: Unassigned » pounard
pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
Status: Active » Needs review
FileSize
560608.patch1.8 KB

This is my first shot with field module, patch definitely needs review

pounard’s picture

pounard
Primary language French
CreditAttribution: pounard commented
FileSize
560608.patch1.67 KB

Proper file (without header junk)

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Needs work

Great !

Aside from the missing '.' at the end of both + // Preprocess fields comments, this is ready to go

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Reviewed & tested by the community
FileSize
field_attach_preprocess.patch1.6 KB

Just fixed the comments. RTBC.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

sun.core’s picture

sun.core CreditAttribution: sun.core commented

This probably needs a re-roll?

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
field_attach_preprocess-560608-9.patch1.71 KB

Rerolled

Status: Needs review » Needs work

The last submitted patch, field_attach_preprocess-560608-9.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Needs review
FileSize
field_attach_preprocess-560608-11.patch1.72 KB

This should work.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Reviewed & tested by the community

Green. Setting RTBC per #6.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -translatable fields

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +translatable fields

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.