I propose that the following changes to the tab structure would improve the useability of this page:

1: If there is only one relationship type defined, then do not show the "All" tab, it is redundant.
2: Move the pending tab to be the last tab always.
3: Add numbers to the tab titles to show how many users are on the tab (e.g. Pending (3)). This is perhaps most useful on the pending tab as a reminder to the user that he has invitations pending.

CommentFileSizeAuthor
#3 ur_relationships_counters_in_tabs.patch4.15 KBsja1
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alex.k’s picture

alex.k CreditAttribution: alex.k commented

1 and 3 would be nice additions. If you can patch the module to provide this, it would be great. 2 is a question of taste, so it's better as a site specific override. Thanks for the feedback.

Bilmar’s picture

Bilmar CreditAttribution: Bilmar commented

Hello,

I also only user one relationship type: 'Friend' at the moment.
This would be a very useful patch =)

sja1’s picture

sja1 CreditAttribution: sja1 commented
Status: Active » Needs review
FileSize
ur_relationships_counters_in_tabs.patch4.15 KB

Here's a patch to do 1 and 3. I've little experience with the menu system so someone may have to "drupalize" the code (assuming it works properly for everyone). I've only modified the tab titles at the "relationships/*" paths, not at the "user/%/relationships" paths or anywhere else. Hopefully someone more expert than I can take this and with little effort get it into a commitable state.

dc1258’s picture

dc1258 CreditAttribution: dc1258 commented

Does this patch work? Also, I am not very experienced with Drupal. How do you install a patch like this?

dc1258’s picture

dc1258 CreditAttribution: dc1258 commented
Status: Needs review » Active

Would you be able to install this patch into the core module?

alex.k’s picture

alex.k CreditAttribution: alex.k commented
Status: Active » Needs review
dc1258’s picture

dc1258 CreditAttribution: dc1258 commented

I am new to all of this but why did you (Alex) post a blank posting? Does that mean this has been added? Does it mean you are just marking that you read the post?

alex.k’s picture

alex.k CreditAttribution: alex.k commented

I just restored the status back to "needs review".

If you want to try the patch, there are some instructions at http://drupal.org/patch/apply

YK85’s picture

YK85 CreditAttribution: YK85 commented

The patch worked great before. However, against the latest dev got the result:

patching file user_relationships_ui/user_relationships_ui.module
Hunk #1 FAILED at 479.
Hunk #2 succeeded at 520 (offset 16 lines).
Hunk #3 succeeded at 533 (offset 16 lines).
Hunk #4 succeeded at 619 (offset 16 lines).
Hunk #5 succeeded at 887 (offset 30 lines).
1 out of 5 hunks FAILED -- saving rejects to file user_relationships_ui/user_relationships_ui.module.rej

I hope this patch can be brought up to the latest dev and at least some parts committed to the core module.
Thanks!

okday’s picture

okday CreditAttribution: okday commented

subscribe

codevoice’s picture

codevoice CreditAttribution: codevoice commented

subscribe

mrf’s picture

mrf CreditAttribution: mrf commented
Status: Needs review » Needs work
FiNeX’s picture

FiNeX CreditAttribution: FiNeX commented

On D7 version the first request is still missing, it could be useful.