Optimize module and theme images

Is this done with any reference at all to:
#552000: Smush core images
that went in last week?

I have no opinion. Just letting you know that if this is important to you, you'll have to go over there and re-open an issue that Dries just committed and closed for "a couple of extra bytes".
Either way, this issue is a duplicate of that. If you have improvements, they'll need to go into that other thread, where folk who have already thought of this can see your version.

Heck, I dunno.
Is reducing the size of images distributed in core this week really more than one task?

Look, either you were unaware of the fix for this exact task that was committed days ago, and needed to have your attention brought to the fact that the team just successfully did exactly this...

...or you were aware of the previous efforts (since you call yours "continuing work") and posted your own replacement version without reference to the previous discussion.

I figured it was just accidental duplication, and let you know FYI. Thanks, but that's already fixed in dev.

If your duplication was actually deliberate because you think your method is significantly better, then it would be reasonable to post at least an update in that other thread.
No?

I'm on board with this submission except for the jQuery UI updates.

Since jQuery UI is basically a third party library, Drupal one day is going to sync with newer releases, and users are doing to start syncing updates probably way before Drupal core gets around to committing upgrades. If you just download a copy of jQuery UI and open your favorite diff tool, it's going to look like the updated version of jQuery UI got updated images, when in fact, they're probably going to be the same, but bigger. In that case, I think it's an undesirable inconsistency. Most other images included with core are Drupal-specific images. An upgrade of Drupal is going to include the same images, and therefore won't make inconsistencies in a diff from version to version.

As for the other images, the hook-rtl.png, hook.png, buttons.png, list-item.png files still got some additional size savings with repeated runs of ImageOptim. I included those updates in the attachment and left out jQuery UI compressed ones.

Toolbar module had a new image since this was submitted, so that is updated. File, simpletest, and shortcut have images that were not included in the original submission, but are in this attachment.

OpenID's image update was handled through #577912: Update OpenID icon with alpha transparency, so I removed that.

The result directory list of this attachment is as follows

./modules/color/images/hook-rtl.png
./modules/color/images/hook.png
./modules/color/images/lock.png
./modules/file/icons/application-octet-stream.png
./modules/file/icons/application-pdf.png
./modules/file/icons/application-x-executable.png
./modules/file/icons/audio-x-generic.png
./modules/file/icons/image-x-generic.png
./modules/file/icons/package-x-generic.png
./modules/file/icons/text-html.png
./modules/file/icons/text-plain.png
./modules/file/icons/text-x-generic.png
./modules/file/icons/text-x-script.png
./modules/file/icons/video-x-generic.png
./modules/file/icons/x-office-document.png
./modules/file/icons/x-office-presentation.png
./modules/file/icons/x-office-spreadsheet.png
./modules/image/sample.png
./modules/shortcut/shortcut.png
./modules/simpletest/files/image-1.png
./modules/simpletest/files/image-test.png
./modules/toolbar/toolbar.png
./themes/garland/color/base.png
./themes/garland/color/preview.png
./themes/garland/images/bg-bar-white.png
./themes/garland/images/bg-content-left.png
./themes/garland/images/bg-content-right.png
./themes/garland/images/bg-navigation-item.png
./themes/garland/images/body.png
./themes/garland/images/gradient-inner.png
./themes/garland/logo.png
./themes/garland/minnelli/color/base.png
./themes/garland/minnelli/color/preview.png
./themes/garland/minnelli/logo.png
./themes/garland/minnelli/screenshot.png
./themes/garland/screenshot.png
./themes/seven/images/add.png
./themes/seven/images/arrow-asc.png
./themes/seven/images/arrow-desc.png
./themes/seven/images/arrow-next.png
./themes/seven/images/arrow-prev.png
./themes/seven/images/buttons.png
./themes/seven/images/list-item.png
./themes/seven/screenshot.png
./themes/stark/logo.png
./themes/stark/screenshot.png

This has been on "needs review" for way too long. I've checked for some of the themes, and meanwhile there are updated and new images in HEAD, so this requires a would reroll with the latest version of the images.

Also, there seems to be a hidden file (i.e. a file starting with a dot) for each normal file or folder, which we don't need.

Here's an updated tarball without the dot files that I freshly ran through ImageOptim again. Some of the files got up to 3 rounds of optimizing. I happened to also notice that misc/configure.png, misc/permissions.png, and modules/overlay/images were chmoded for Windows, so I changed them to 644.

deekayen@davidn-ubuntu:~/Desktop/562968_smaller_images$ ls -R
./misc:
configure.png  druplicon.png  permissions.png     watchdog-ok.png
draggable.png  help.png       watchdog-error.png  watchdog-warning.png

./modules/color/images:
hook.png  hook-rtl.png  lock.png

./modules/contextual/images:
gear-select.png

./modules/file/icons:
application-octet-stream.png  package-x-generic.png  video-x-generic.png
application-pdf.png           text-html.png          x-office-document.png
application-x-executable.png  text-plain.png         x-office-presentation.png
audio-x-generic.png           text-x-generic.png     x-office-spreadsheet.png
image-x-generic.png           text-x-script.png

./modules/image:
sample.png

./modules/openid:
login-bg.png

./modules/overlay/images:
close.png

./modules/shortcut:
shortcut.png

./modules/simpletest/files:
image-1.png  image-2.jpg  image-test.jpg  image-test.png

./themes/garland:
color  images  logo.png  screenshot.png

./themes/garland/color:
base.png  preview.png

./themes/garland/images:
bg-bar-white.png     bg-content-right.png    body.png
bg-content-left.png  bg-navigation-item.png  gradient-inner.png

./themes/seven:
images  logo.png  screenshot.png

./themes/seven/images:
add.png        arrow-desc.png  arrow-prev.png  list-item.png   task-item.png
arrow-asc.png  arrow-next.png  buttons.png     task-check.png

./themes/stark:
logo.png  screenshot.png

There seem to be some images missing. For example:
In /misc I see the following files:

arrow-asc.png      forum-hot.png           permissions.png*          powered-gray-88x31.png
arrow-desc.png     forum-new.png           powered-black-135x42.png  tree-bottom.png
configure.png*     forum-sticky.png        powered-black-80x15.png   tree.png
draggable.png      grippie.png             powered-black-88x31.png   watchdog-error.png
druplicon.png      help.png                powered-blue-135x42.png   watchdog-ok.png
feed.png           menu-collapsed.png      powered-blue-80x15.png    watchdog-warning.png
forum-closed.png   menu-collapsed-rtl.png  powered-blue-88x31.png
forum-default.png  menu-expanded.png       powered-gray-135x42.png
forum-hot-new.png  menu-leaf.png           powered-gray-80x15.png

Is there some reason some files are not included?
Also, the openid image should be excluded, as it is being replaced at #577912: Update OpenID icon with alpha transparency

#552000: Smush core images already optimized many images, but I'll repackage w/o the openid image when I get back to my laptop.

never mind, the openid image was already committed last september, didn't notice it was still open just for drupal 5.
So it's actually good it's here. Setting this to needs review (sorry, not awake enough to completely review all images now...)

Images look good.

Committed to CVS HEAD. Thanks.