This bug is only triggered when using a timeout value of 0. When using a 0 value in combination with next or prev settings to the jquery cycle plugin this should normally make the slideshow become fully manual (requiring the user to click 'next' / 'prev' buttons). However, if you set this to 0 in views_slideshow, the slideshow actually just starts switching very rapidly. I believe this is due to the value in settings.timeout being a string, not an int. When I cast it to an int it seems to work as it should.

This is the code in question:

    var settings = Drupal.settings.viewsSlideshowThumbnailHover[fullId];
    settings.targetId = '#' + $(fullId + " :first").attr('id');
    settings.opts = {
      fx:settings.effect,
      speed:settings.speed,
      timeout:settings.timeout,

The attached patch fixes this by simply adding parseInt(settings.timeout).

Files: 
CommentFileSizeAuthor
views_slideshow_timeout_int.patch961 byteshadsie

Comments

Status:Needs review» Reviewed & tested by the community

I can verify that this fixes the issue. I will commit as soon as I get a couple of other items committed.

Status:Reviewed & tested by the community» Fixed

Committed this. Thanks a lot!!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.