user_access(NULL, NULL, TRUE) is only called internally from user.module.

We should apply a consistent DX standard for resetting static variables. Having some functions with a $reset parameter and some others using drupal_static() doesn't make sense.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

Status: Needs work » Needs review
FileSize
6.84 KB

oh wow - a pass-through $reset parameter! :)

And. A missing cache flush in user_role_save()! ;)

Status: Needs review » Needs work

The last submitted patch failed testing.

sun’s picture

Status: Needs work » Needs review
FileSize
7.02 KB
catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks great!

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -API clean-up

Automatically closed -- issue fixed for 2 weeks with no activity.