uc_checkout_pane_cart() needs a theme function for the table on the order review page [#577794]

Comment	File	Size	Author
#9	itemtheme.patch	3.23 KB	arski

#5	itemtheme.patch	2.57 KB	arski

Comment #1

rszrama CreditAttribution: rszrama commented 15 September 2009 at 14:08

Yeah, I actually will be rolling out a 1.8 to coincide with the 2.0 release... getting a patch into 2.x would be ideal, though we probably won't review / include it till 2.1.

Log in or register to post comments

Comment #2

crashtest_ CreditAttribution: crashtest_ commented 15 October 2009 at 16:02

Greg, I would appreciate the patch even if it doesn't get applied immediately. Still willing?

Thanks,

Pat

Log in or register to post comments

Comment #3

greg.harvey

English

CreditAttribution: greg.harvey commented 15 October 2009 at 16:24

Hi Pat - I didn't actually make the patch in the end, because thill_ from Commerce Guys put me on to a module where you can disable the whole review page. He even felt the review page sometimes harmed conversion rates, looking at stats from some of their clients.

This is what I used: http://www.ubercart.org/contrib/497

Log in or register to post comments

Comment #4

arski CreditAttribution: arski commented 7 February 2010 at 23:06

Hi guys,

I just ran into the same problem - It would be really great if the output of uc_checkout_pane_cart() were themed so that it could be customized along with the rest of the review table.

PS. I'm running the 6x version of the module - don't need to open an extra issue for that do I?

Thanks a lot,
Martin

Log in or register to post comments

Comment #5

arski CreditAttribution: arski commented 19 February 2010 at 15:37

Version:

5.x-1.7

» 6.x-2.2

File	Size
itemtheme.patch	2.57 KB

Submitting a patch for the 6.x version. Let me know if anything is wrong with it, it's my first patch :)

Log in or register to post comments

Comment #6

greg.harvey

English

CreditAttribution: greg.harvey commented 19 February 2010 at 16:00

Version:

6.x-2.2

» 6.x-2.x-dev

I think that's a great start. However, my only comment would be since this is a D6 patch a template would be even cooler than a theme function! =)

Patches should be against dev, btw, as that's where they'll be committed.

Log in or register to post comments

Comment #7

arski CreditAttribution: arski commented 19 February 2010 at 17:01

Yea, you're probably right about a template.. But that would mean updating all theme functions to templates which might be something for a later day :)

Log in or register to post comments

Comment #8

TR CreditAttribution: TR commented 20 February 2010 at 02:54

Status:

Active

» Needs work

Instead of just passing $item->qty you should pass the whole $item, that way the theme function will have access to all the additional information about the product.

One thing I don't like about this patch is that it doesn't give the end user a way to add a column to the table, which is probably the most frequent thing people ask for. I think that will require moving more of the functionality into the theme function and not just confining the theme function to outputting one row of HTML.

And yes, I would appreciate if you made your patch against the -dev version - that requires you to download the current -dev and install it on your site. Although if you made the patch against the 6.x-2.2 version then that is the one that should be assigned to this issue.