after the upgrade to d6.13 (and now 6.14) style stripper stop working or rather its not possible to change the settings again.

So if go into a themes stylestripper settings and wanna modif them (add or remove a css file) the message from the system is "them dont exist"

CommentFileSizeAuthor
#2 theme_does_not_exists.patch945 bytessreynen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

beltofte’s picture

Is the theme that gives the error enabled in the theme administration?

The error is outputtet if the theme is not enabled. I have just testet it on a clean d.6.14 installation and it works fine here.

sreynen’s picture

Status: Active » Needs review
FileSize
945 bytes

I'm having this problem with the theme enabled and default. The problem seems to be that it's checking arg(4), but the theme is actually in arg(3), after admin (0), themes (1), and stylestripper (2). Not sure why this would have changed, but changing 4 to 3 in the code fixes the problem for me.

I've attached a patch that fixes this, and also gives a more informative error message when it fails.

beltofte’s picture

Status: Needs review » Fixed

I have looked at the problem. And it looks like the problem is related to the admin module. In D6 are the themes placed in admin/structure/themes, which works fine with the stylestripper module as it expects the theme name in arg(4). The problem is that the admin module creates a new path admin/themes which will then have an empty arg(4) and the theme name in arg(3) (admin/themes/stylestripper/garland). So the patch attached in #2 will only work when accessing the themes the appearance link in top overlay bar or the left side bar in the admin module.

A check has been added instead of the patch in #2, so it works with the admin module. Furthermore is the error message changed, but made the "Drupal way" instead of the suggestion included in the patch in #2.

beltofte’s picture

Assigned: Unassigned » beltofte
Status: Fixed » Closed (fixed)