Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Looks like a line of code got missed when refactoring...
securepages_redirect() uses it but does not declare it as global, while securepages_boot() declare $base_url as global but does not use it and calls securepages_redirect().
This is likely the cause of many issues I have seen listed( imagecache urls, form #actions etc...) , adding global definition to that function fixed these issues for me.
Will submit patch shortly.
Comment | File | Size | Author |
---|---|---|---|
#1 | globalbase_url-6.x-1.x-dev.patch | 616 bytes | JimBroad |
#1 | globalbase_url_6.x-1.8.patch | 616 bytes | JimBroad |
Comments
Comment #1
JimBroad CreditAttribution: JimBroad commentedSubmitting patches for 6.x-1.8 and 6.x-1.x-dev
Comment #2
ppcc CreditAttribution: ppcc commentedsubscribing
Comment #3
gordon CreditAttribution: gordon commentedThanks I have fixed this.
Comment #5
Bartezz CreditAttribution: Bartezz commentedHi,
I've applied your patch as I was having problems with image cache.
I'm using secure pages on my webform nodes which works fine if the nodes do not contain any images provides by image cache.
Yet as soon as images are placed via image cache the pages loose their 'lock' after a second of loading (when the image cache image is loaded I presume).
Was hoping this patch would solve it, yet it doesn't in my case.
I should explain that I have not defined 'Non-secure Base URL' or 'Secure Base URL' under admin/build/securepages
The reason for this is that I'm using domain access module and my base url varies from http://one.example.com to http://two.example.com
Not sure where to start in trying to fix this problem.
Regards
Comment #6
Bartezz CreditAttribution: Bartezz commentedFound a solution to my imagecached images causing problems
My secure pages setup:
- enabled
- checked: Switch back to http pages when there are no matches
- Non-secure Base URL: (nothing)
- Secure Base URL: (nothing)
- checked: Make secure only the listed pages.
- pages: (the pages you want secured)
- Ignore pages:
*/autocomplete/*
*/ajax/*
*/imagecache/*
Special attention for */imagecache/*
This worked for me!
Cheers
Comment #7
mrcharles CreditAttribution: mrcharles commentedPatch works like a treat - thanks Jim
Comment #8
cangeceiro CreditAttribution: cangeceiro commentedPatch and settings worked for me as well. Is this patch going to get committed?
Comment #9
sillygwailoIt doesn't look like this patch ever got committed. Re-opening.
For me, this seems to solve the following problem:
user
path means that going to http://subdomain1.example.com/user redirects tohttps://example.com/user
.https://subdomain1.example.com/user
.Without the patch: #2 happens. With the patch: #3, which is expected, happens.
Comment #10
grub3 CreditAttribution: grub3 commentedSubscribe.
Comment #11
grendzy CreditAttribution: grendzy commentedI believe this patch has been applied to the -dev version. See http://drupalcode.org/viewvc/drupal/contributions/modules/securepages/se...
There hasn't been a new release for a while, so 1.8 doesn't contain this fix. I'm currently working on 7.x port - but once that's finished a new 6.x-1.9 release is next on the roadmap.
Comment #12
thedeed CreditAttribution: thedeed commentedGrendzy,
I'm having issues adding the (globalbase_url-6.x-1.x-dev.patch) patch to the Secure Pages-6.x-1.x-dev module. The only thing that is not working is the Images in my Ubercart shopping cart, is when I'm in the cart and the page goes to non secure mode. Could you be so kind to upload me a patched copy of the dev module.
Thanks
Comment #13
grendzy CreditAttribution: grendzy commentedIf you have the latest dev release (2010-Oct-27) then the patch has already been applied.