Could you please let us know what makes your module different from an already existing and community-supported http://drupal.org/project/admin_theme? If there isn't much of a difference, would you be open to considering coordinating and cooperating with the admin_theme.module?

Comments

pounard’s picture

Version: » 6.x-1.1

Well I didn't knewn about this module (1 among 5000 regsitred). Indeed, it looks like it a lot.
We wrote it in the company I work for this one for some particular use case, and the compatibility with the 'admin' module is one of it, and it works well and is really lite. Maybe that's the difference?
I'll spend some time within this week to check the other one and try to contribute in case this one is too similar.

pounard’s picture

Thanks for noticing, BTW I asked on #drupal before I commit it, nobody answered it was a duplicate.

austintnacious’s picture

Admin_theme has some problems which I don't believe are properly resolved tho' the maintainer has marked my issue as "won't fix".

Specifically admin_theme does not properly exclude pages listed as "do not use admin theme on these paths".

So, for example, you cannot exculed the admin theme from appearing on the admin/build/blocks page.

I gave up and de-installed admin_theme due to this problem (everytime I tried to move blocks around my site would get screwed up since my admin theme and default themes have different regions).

I don't know if System Theme++ works yet (I decided to look at the issues first before trying it because of my experience with admin_theme) but it does seem to be different in that it appears to be all about only showing the admin theme on specific paths.

Dave Reid’s picture

@austintnacious: With all due respect your request really is something that can't be properly handled by admin_theme or this module, because block.module sets the global $custom_theme after all hook_init() calls. See http://api.drupal.org/api/function/block_admin_display/6

pounard’s picture

Ok so, it seems that admin_theme seems to have some issues. I looked at the module code, I don't like it (but this is only a personal opinion).

I would say that the real feature of system_theme is it's really light, it uses only 2 variables, and 1 cache entry to work; and provide a great integration with admin module; and a hook_system_theme() which allow other modules to provide facilities. That's how this module is different.

If a lot of people complains about the duplicate, I will do something about it (like contributing to admin_theme module is probably the best option) meanwhile I'll just continue to maintain system_theme.

I let this issue open for a few days so people can complain :)

Dave Reid’s picture

@pounard: You're not understanding what I'm saying. Theming the admin/build/blocks pages is going to cause the same problem with this module as well. It's not a problem with admin_theme, it's possibly a bug/feature with Drupal core (#581118: Blocks admin user interface should not do theme switching).

Lightweight: I'd also call admin_theme a light module as well. 7.68 KB for system_theme and 10.42 KB for admin_theme. They're both small in respect to modules.

Integration: admin_theme also has hooks for letting other modules tell it which paths should be covered on admin/themes: hook_admin_theme_options. It says so right on the project page. So again, not different.

pounard’s picture

@Dave Reid
You're right, it's true it looks like a duplicate a lot.

I'll go to a deeper look into the other module when I'll have some free time.

EDIT: typo errors.
EDIT: PS: a light codebase does not make a module light. I was thinking about performance.

mdekkers’s picture

I would just like to say that I am not a big fan of this "duplicate module witchhunt" thing. There are many ways that lead to Rome, and more then anything else, it stifles innovation to no end, and strongly encourages an unhealthy sense of group-think. pounard is graciously sharing with the community some of the work he has been doing in his company, and both pounard as well as his company should be thanked for this generosity, not told to "take it away elsewhere, we already do this kind of thing" - whilst the end functionality might already be available, there might be a specific use-case that is satisfied, a prettier code base, or just an approach that sits much better with a given user.

And yes - I am aware of the whole "we can't confuse the poor user" argument. Well, if you create a system exclusively tuned for the lowest common denominator, then your system will become the lowest common denominator. I, for one, am happy that there are different modules out there that do the same thing - it makes it oodles easier for me to decide to go with contributed code, or roll my own. If there was only one of each, I would be rolling my own most of the time.

Thanks, pounard, for giving me the choice.

(edit - typos)

pounard’s picture

Thanks for you comment.
I will keep maintaining this module not only because we use it in production sites but also because it could be useful to some other people.

EDIT: but somehow, I admit that DaveReid is right, but because the community is made of different people with different point of views, duplicate modules is not something we can not avoid. I'll be glad to communicate with the duplicate module maintainer so we can help users to differenciate both modules by adding pertinent descriptions on project pages.

pounard’s picture

Status: Active » Closed (fixed)

I close the issue. This module is a duplicate, but I use it anyway on some production sites. If people consider using it, or are already using it, know that I'll keep maintain it so don't hesitate posting bug or feature requests.

Wolfflow’s picture

I'm curious to how this is going to develop. Will take a look at the System_Theme.

lelizondo’s picture

I been using both modules for about a week, first I tried the admin_theme because it has a better name. But honestly, it didn't work as I expected. Every time I submit a form and the cache gets cleared (like when installing a module) I see the non-admin theme. This module, is working so much better.

pounard’s picture

Thank you for your comment. If you need features, please ask!