The diff module has a default implementation which expects cck types to store their values in $item['value']. This is not the case for email, which uses $item['email'].

Ideally email would use 'value' however until then I have written a patch that implements hook_content_diff_values() instead and uses the 'email' value.

CommentFileSizeAuthor
email_diff.patch644 bytesserenecloud
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

serenecloud’s picture

This patch is 6 weeks old and nothing has happened - can a maintainer please review?

kerberos’s picture

We're have this issue as well. Haven't tried the patch yet.

kerberos’s picture

Status: Active » Needs review

Applied the patch and it works like a charm.

-Daniel

patchak’s picture

Hey there, I just installed the latest dev version of this module, but still I can't seem to see the diff for the email field, would there be anything special to do?

For what version of diff is this done?

I use the : 6.x-2.0 and the latest dev from this module, and still no luck seeing the diffs!
Thanks for any help,
Alexis

Countzero’s picture

Thanks for this patch. Works perfectly.

By the way, it's really bad practice, but I just pasted the code in a custom module for easier maintenance. I had to use a patch for the link module too, plus one custom code for a special field of mine, so it started to become unbearable.

Encarte’s picture

Status: Needs review » Reviewed & tested by the community
Alan D.’s picture

Cross-posting #1685698: Provide field support for diff - this provides Diff 7.x-3.x support.