The current configuration has layer types defining whether they are base layers or overlays. This is a layer property which should be modified at render, in my book.

This will initially be committed into the 0.x branch.

CommentFileSizeAuthor
#4 overlay_baselayer_unification.patch6.93 KBtmcw
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Component: OpenLayers Preset UI » OpenLayers API
Status: Active » Postponed

Postponed; this is a lot of UI work and doesn't have any immediate benefit beyond coolness.

zzolo’s picture

zzolo CreditAttribution: zzolo commented

In my own ignorance, I am not sure what the benefit of this would be?

tmcw’s picture

tmcw CreditAttribution: tmcw commented

The benefit is that users will want TMS layers as either baselayers or overlays, and the UI at this point has no way of supporting this. Since every layer type in OpenLayers can be either, the distinction, and its definition in the layer type objects, is wrong in this module. Basically we need a per-map or per-layer (but in the base layer class) setting of whether something is a baselayer or an overlay.

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Status: Postponed » Active
FileSize
overlay_baselayer_unification.patch6.93 KB

This will need to be an ongoing effort, but here's the first swipe at it - this basically starts to rework the administration interface to not care about the baselayers / overlays distinction off the bat. It also seems like switching the AHAH-loading of different layers on different projections should be rewritten as a ctools form dependency.

KrisBulman’s picture

KrisBulman CreditAttribution: KrisBulman commented

this is great! I haven't tried the patch yet, but I have set up a tilecache served from a WMS (from mapwarper) that displays my baselayer and initial overlay

I don't quite have it right yet as it's shifted to the right a bit, but it's progress.. can't wait to try it

permalink view on the test openlayers map that zooms to the correct location:

http://mapserver.bulman.ca/cgi/tilecache/?zoom=12&lat=46.78673&lon=-64.0...

my base layers & overlay

http://mapserver.bulman.ca/cgi/tilecache/tilecache.cgi/1.0.0/

whole overlay

http://mapserver.bulman.ca/cgi/tilecache/tilecache.cgi?LAYERS=map_30&FOR...

zzolo’s picture

zzolo CreditAttribution: zzolo commented

Initial sight review of patch looks good. Obviously this is still missing the rendering side. Nice work.

tmcw’s picture

tmcw CreditAttribution: tmcw commented
Status: Active » Closed (works as designed)

Marking as by design. The layer sorting/ordering work will be a big part of this, but I don't think it's appropriate to implement this until layers are unified, as they will be in OpenLayers 3.