I need to extend this module to be able to support multiple GROUP BY clauses and aggregate functions, right now it looks like it's restricted to just one per-view.

However before making further patches to this module, it would be appreciated if the code could be updated to more closely line up with http://drupal.org/coding-standards. Right now the indentation is off in places, there's lots of extra whitespace at the end of lines, and the PHPdoc and comment structure is inconsistent.

This patch brings the code closer to the official standards. I left most cruft in place (that can be removed later) in case it's there for a later purpose.

CommentFileSizeAuthor
views_groupby_code_style.patch13.35 KBquicksketch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

irakli’s picture

irakli CreditAttribution: irakli commented

Nathan,

many thanks for the patch.

On another note do you mind if I add you to this module? :) I have no doubt the module could benefit from your contributions and I'd like to save you the headache of submitting patches every time.

Thanks.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented

I would love that! I doubt I'll be a frequent maintainer, I've got tons of modules already ;-) But I'd love to help out while I'm working on my current project!

irakli’s picture

irakli CreditAttribution: irakli commented

Done.

Great to have you on-board.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Needs review » Fixed

Great, well first order of business I've committed this patch. I'll review the issue queue and see if I can clean up any of the other issues. Thanks!

irakli’s picture

irakli CreditAttribution: irakli commented

Thanks a lot, Nathan.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.