Non-GPL code included in Fancybox CVS folder [#623664]

The following files are not licensed with the GPL and should not be included in the CVS repository:

jquery.easing.1.3.js (BSD)
jquery.fancybox-1.2.1.js (MIT)
jquery.fancybox-1.2.1.pack.js (MIT)

1. In general 3rd party libraries are forbidden, so do not commit it. Document for your users how to find and install it.
2. They are absolutely and always forbidden unless if they are licensed under GPL or GPL v2+ or they have a broader license and can be re-licensed under the GPL. GPL "compatible" code is not allowed.
3. Exceptions can be made if the 3rd party library:
- 1. had to be modified to work with Drupal and this modifications wasn't accepted by the original author
- 2. is generally difficult to find in the needed version. This is true or used to be true for some jQuery plugins.
- 3. is no longer maintained by the original author

Comments

Comment #1

bas.hr CreditAttribution: bas.hr commented 5 November 2009 at 08:52

Since 2009/10/28 fancybox i dual licenced MIT and GPL.
It should only be updated.

Comment #2

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno commented 5 November 2009 at 09:17

Files available from third-party sites should not be included in Drupal.org CVS. That is valid independently from the license used for those files.
This is clearly stated in 3rd party libraries in Drupal CVS, as Dave already reported.

Comment #3

ximo CreditAttribution: ximo commented 6 November 2009 at 14:01

Assigned:

Unassigned

» ximo

Like bas.hr said, Fancybox is now dual licensed under GPL (I actually asked the developer of Fancybox if he could do this).

bas.hr and myself just gained maintainership of the module and will release a new 5.x version with GPL licensed Fancybox files shortly.

Edit: Sorry, was too fast there, didn't read your comment. Alright then, we'll release a version without the plugin and instruct users to download it from code.google.com. Thanks for raising the flag!

Comment #4

jsm174 CreditAttribution: jsm174 commented 6 November 2009 at 16:06

What about not including it all, and moving it the libraries folder like WYSIWYG does with editors?

Fancybox had quite a few versions this past week including changing the
CSS filename to include the version number. We could put code in to detect and show the version as well.

I'd like to make the changes to the 6.x and finally get it in CVS.

-- Jason

Edit: Just saw your edit. I'm still for putting it in the libraries folder.

Comment #5

ximo CreditAttribution: ximo commented 9 November 2009 at 08:52

jsm174: I'm working on a pretty extensive rewrite of the module for the D6 branch. I'll commit the code shortly, so hold your horses :) Good suggestion about automatically detecting the version!