Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
settings['hostname']
doesn't match variable_get('dblog_host_filter:comparison', ...)
instead it should be $settings['dblog_host_filter:comparison']
Comment | File | Size | Author |
---|---|---|---|
#2 | 2009-11-24_select_instead_of_textfield_for_hostname.patch | 3.5 KB | arhak |
Comments
Comment #1
arhak CreditAttribution: arhak commentednow a days I think it doesn't have any usability to set up the hostname search with any other option than contains
moreover NancyDru recommends to switch it to a select instead of a free textfield
and she made her point http://drupal.org/node/578488#comment-2125974
then this would be a support request which will wipe out the bug described above
PS: current bug doesn't affect users, since the default behavior is "contains", just the settings page offers 4 options that will be ignored: exact match, contains, starts with & ends with
Comment #2
arhak CreditAttribution: arhak commentedhostname list will be limited due to log entries limit, but there might be several hostnames/IPs, since every access/login/logout from an external IP will create an entry
debate for having this as a select/textfield or even an autocomplete can be opened in another issue
but leaving here some bullets about it:
- having a select keeps uniformity between filters widgets
- since hostnames aren't showed at "Recent log" table there is no way to guess which one we might be interested on
- an auto-complete widget would have to be implemented from scratch, (username might use core's implementation, but this one does not exists)
- having a plain textfield would be pretty much unusable, since the administratios would have to guess what he/she is looking for (in this case I vote in favor of a "contains" operator and no other operator)
Comment #3
arhak CreditAttribution: arhak commentedNOTE: this patch should remove file
dblog_filters.host.admin.inc
no longer used after this patch
Comment #4
arhak CreditAttribution: arhak commentedwhat about this one?
Comment #5
NancyDruI did what I did earlier because I had a few little problems in Util on a site I'm finishing up and decided to go ahead an fix them. This is a larger fix, so I haven't gotten to it yet. I spent more time on this than I should have already. (Damned IE)
Comment #6
NancyDru6.x no longer supported