settings['hostname'] doesn't match variable_get('dblog_host_filter:comparison', ...)

instead it should be $settings['dblog_host_filter:comparison']

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

arhak’s picture

Title: $settings['hostname'] doesn't match variable_get('dblog_host_filter:comparison', ...) » use select instead of textfield for hostname filter
Category: bug » support
Priority: Minor » Normal
Issue tags: -Quick fix

now a days I think it doesn't have any usability to set up the hostname search with any other option than contains

moreover NancyDru recommends to switch it to a select instead of a free textfield
and she made her point http://drupal.org/node/578488#comment-2125974

then this would be a support request which will wipe out the bug described above

PS: current bug doesn't affect users, since the default behavior is "contains", just the settings page offers 4 options that will be ignored: exact match, contains, starts with & ends with

arhak’s picture

Status: Active » Needs review
FileSize
3.5 KB

hostname list will be limited due to log entries limit, but there might be several hostnames/IPs, since every access/login/logout from an external IP will create an entry

debate for having this as a select/textfield or even an autocomplete can be opened in another issue
but leaving here some bullets about it:
- having a select keeps uniformity between filters widgets
- since hostnames aren't showed at "Recent log" table there is no way to guess which one we might be interested on
- an auto-complete widget would have to be implemented from scratch, (username might use core's implementation, but this one does not exists)
- having a plain textfield would be pretty much unusable, since the administratios would have to guess what he/she is looking for (in this case I vote in favor of a "contains" operator and no other operator)

arhak’s picture

NOTE: this patch should remove file dblog_filters.host.admin.inc
no longer used after this patch

arhak’s picture

what about this one?

NancyDru’s picture

I did what I did earlier because I had a few little problems in Util on a site I'm finishing up and decided to go ahead an fix them. This is a larger fix, so I haven't gotten to it yet. I spent more time on this than I should have already. (Damned IE)

NancyDru’s picture

Issue summary: View changes
Status: Needs review » Closed (outdated)

6.x no longer supported