corresponding node reference not removed on deletion of a node

It could be a cache problem.
What happens when you manualy flush the cache on admin/settings/performance? Is the deleted node gone in the node reference field?
Unfortunaly I dont seem to able to duplicate the problem.

This is my setup
I have three node types
Job
Office
Client

a job has a ref to an office and a client and the other two have a ref to the job.

I enabled normal caching. Deleted a job, the reference also disappeared on both the office and the client. In the database all is well too.

Cnr does flush the content cache when inserts and updates occur but not on deletion since drupal already does that. Do you have the latest core installed?

A possible sollution would be to flush that cache on deletion the same way as on updating and inserting. Try putting this function corresponding_node_references_clear_cache($node) in hook nodeapi where the delete operator is active in the switch.
You should end up with this.

function corresponding_node_references_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
  //the hook wont be executed when not updating, deleting or inserting
  if (!($op == 'delete' || $op == 'update' || $op == 'insert' )) { 
    return; 
  }
  $result = db_query("SELECT node_types_content_fields FROM {corresponding_node_references} WHERE enabled = %d", 1);
  switch ($op) {
    case delete:
      while ($row = db_fetch_object($result)) {
        $key = explode('*', $row->node_types_content_fields);
        switch ($node->type) {
          case $key[0]:
            corresponding_node_references_remove_node_refs_after_delete($node->nid, $key[3].'_nid', 'content_'.$key[3]);
            break;
          case $key[2]:
            corresponding_node_references_remove_node_refs_after_delete($node->nid, $key[1].'_nid', 'content_'.$key[1]);      
            break;
        }
      }
      //this functions already clears the cache when inserting and updating references

      corresponding_node_references_clear_cache($node);

      break;
    case update:
    case insert:      
...

Let me know if this solves your problem.
If not perhaps you could provide me the exact configuration of your node references and corresponding node references? Or perhaps you could send me a dump of your database and a copy of your code of the entire site if no security issues are involved.

Closing it since no one is giving feedback

Hello,

I face the same problem, and I think the posted code differs from the original code in cnr.module a lot, it's not just a call to clear_cache() function. I tried emptying the cached data but nothing. the referenced node reference still exist in the field_content_NODE_REFERENCE field in the database. so, is there a solution for such a problem!?

Subscribes :( Can not solve this problem :(
domidc, how can I help to you for understanding this issue?

I have found a cause of error!

function corresponding_node_references_delete($home_node, $home_field, $away_node_type, $away_field) {
// Iterate through the field's references.
foreach ($home_node->$home_field as $reference) {
if (!empty($reference['nid'])) {
// Load the referenced node if it is of the specified away type.
if ($referenced_node = node_load(array('nid' => $nid, 'type' => $away_node_type))) {
// Iterate through the away node's references.
foreach ($referenced_node->$away_field as $key => $value) {
// Remove references to the deleted node.
if ($value['nid'] && $value['nid'] == $home_node->nid) {
unset($referenced_node->{$away_field}[$key]);
_corresponding_node_references_update($referenced_node);
break;
}
}
}
}
}
}

Threre are the check: if (!empty($reference['nid']))
But further the text follows: node_load(array('nid' => $nid, 'type' => $away_node_type)),
The variable $nid is not defined. It is necessary to use $reference['nid'].

@domidc #5
Me and CkPoMHbIu have subscribed this issue and we are eager to give you the info you need if the current is insufficient.

There is a temp solution for this bug. I created a custom module implementing the hook_nodeapi(), in case of deletion specific content types I search for the node id in the relation fields table and delete this relation myself, I find this fix is not right but just a quick fix, but such a feature should exist in the CNR module itself.

Guys I ll look to it tomorrow, then we have a holiday in Belgium.

Subscribing..

subscribing

Well

function _corresponding_node_references_update($node) {
  content_update($node);
}

seem to have the problem, this code snippet is from the corresponding_node_references.crud.inc line number 144
content_update() doesn't really update well, which it sets the references to NULL but doesn't entirely remove this row, this is it for now. I might end up replacing this line with deleting the original node and add the new updated node, but this solution is just for now and not acceptable at all.
Another solution is to add an sql statement "delete from the content_field__REFERENCING_TABLE where REFERENCING_VALUE is null"

Any other solutions ?

subscribing

subscribing

subscribe

Patch in #8 seems to work fine. I checked DB - after patching it cleans up links for deleted nodes (which were left untouched causing problems before).
I think it should be reviewed and applied in the next release.

This is included in version 6.4 which is currently still in dev.

So no patch? What is the patch in #8? How do we apply?

This issue was fixed in 4.1