Was just trying this module out on a test site with PHP safe_mode enabled, and I noticed that the filesystem storage service uses the disk_free_space() function to determine how much free space is available. While this is certainly useful information, it triggers an error when disk_free_space() is unavailable.

I wrote a simple patch that addresses the issue; however, I haven't really looked at the rest of the code base, so I can't confirm that this doesn't break anything else …does this look like a good idea?

Alternatively, if the module is going to require functions like this that are disabled in certain security setups, it may be worth adding a note to the documentation about it.

Thanks!
Adam

CommentFileSizeAuthor
disk_free_space.patch931 bytesjazzslider
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jbrown’s picture

Assigned: Unassigned » jbrown

Its actually a requirement for Drupal to be run without safe mode: http://drupal.org/requirements

If there is demand for storage_api to work with safe mode, then I'll support it.

jbrown’s picture

Status: Needs review » Closed (fixed)