In lot of case, there can be minor typos like missing "." at the end of the row or use of wrong quotation marks in some languages etc. In these case, if the moderator corrects the string he takes the authorship too which is not fair.
What I suggest is a checkbox button for every string what indicates the ownership. This should be checked by default (the moderator should uncheck it if he corrects the useless translation).
A more complex case can be a 3 stage select box for those cases where the suggestion is corrects an existing translation. Who should be the author of the string? The moderator could deciede.
Comment | File | Size | Author |
---|---|---|---|
#26 | l10n_server keep original translator.png | 23.61 KB | Pomliane |
#24 | 632120-24-re_author_suggestion.patch | 7.41 KB | SebCorbin |
#22 | 632120-22-re_author_suggestion.patch | 8.48 KB | SebCorbin |
#22 | Screenshot_30_01_13_17_14-5.png | 77.34 KB | SebCorbin |
#18 | l10n_server_reauthor_632120_18.patch | 5.72 KB | SebCorbin |
Comments
Comment #1
Takafumi CreditAttribution: Takafumi commented+1 for this feature.
Comment #2
nevergone CreditAttribution: nevergone commented+1
I need :)
Comment #3
asrob+1
Comment #4
Takafumi CreditAttribution: Takafumi commentedPlease review this patch.
Comment #5
Gábor Hojtsy@Takafumi: I don't understand why does this patch lists all the usernames for all people who have active suggestions in a dropdown to pick? That seems to be too much to offer here. What's the use case?
Comment #6
Takafumi CreditAttribution: Takafumi commented@Gábor: l10n_server allows two or more suggestions, but even in that case, only one suggestion can be edited. So, all usernames who have active suggestions will have to be listed, and then, moderator can determine a translator.
Comment #7
Gábor HojtsyIs it that you pick the suggestion closest to what you'd accept, right? Then why would you pick anybody else but you or the suggestor to take credit? I'm not getting this.
Comment #8
Takafumi CreditAttribution: Takafumi commented@Gábor: You might want to imagine the case with the first post.
Comment #9
Gábor HojtsyAh, you mean this one:
That indeed seems like what you've attempted to solve, right.
Comment #10
droplet CreditAttribution: droplet commentedcan we make it easier ? compare different between 2 suggestions automatic. if changes less than X%, make it as "minor changes"(whatever you want to call). and it need to keep a records for their contributors works too. I would like to be a Top minor contributors showing on L.D.O pages.
Comment #12
palik CreditAttribution: palik commented+1, subscribing :)
Comment #13
droplet CreditAttribution: droplet commentedrecalling people to focus on it :)
I can see my point getting up a lot by minor fixing a "."
#4, #9
I don't get any idea of this 2 point :(
for now, it may have
original translator
suggestion translator
ME
if I submit a new string / approve a suggestion, translator change to ME/suggestion translator.
if I want to keep "original translator as translator", it should provide ONE option only.
so we need to provide a CLICK BOX only ??
Comment #14
danillonunes CreditAttribution: danillonunes commentedI don't know if an selectbox or checkbox is required.
I think that every time I click "Edit a copy" icon, the translation can be saved as "Suggestion by xyz, Edited by abc.". If I want make a new translation without one previous suggestion, I click on <New translation>.
Comment #15
kulcsi CreditAttribution: kulcsi commentedThe main translator in most of the cases can be calculated based on the number of new/modified characters commited by the translators. The translation should be automatically attributed to the person who have modified the most no. of characters.
We should give the opportunity to the moderator to change the default value of the "attributed to" metadata.
Comment #16
wundo CreditAttribution: wundo commentedsubscribing
Comment #17
SebCorbin CreditAttribution: SebCorbin commentedI would also like to see this implemented. This is quite easy, so I'll do the code.
So we have currently two possibilities :
Both ways, the original contributor comes from the "Edit a copy" button.
Which one do you like? (We can also combine the two)
Comment #18
SebCorbin CreditAttribution: SebCorbin commentedFirst patch, first impressions: this module is a mess :(
FAPI is hardly respected, I had to follow this mess to make a quick patch, but I'd better see the translation.inc file rewritten...
Please review this patch (which is against 6.x-3.x-dev)
Comment #19
droplet CreditAttribution: droplet commented@SebCorbin,
I edit my own translation and also show this:
"Re-author this suggestion to droplet"
another cool way is make "User Name" to be ajax editable, let admin change to any username.
(anyway, now is enough for 95% cases)
another problem, edit textfield keeps moving, its quite hard to cancel the checkbox:
#1228398: Keep textarea expanded when editing suggestion
Comment #20
SebCorbin CreditAttribution: SebCorbin commentedI don't agree with the fact to put any username for two reasons:
I totally agree that the current code is enough for 95% cases.
I'll look into the other issue.
Comment #22
SebCorbin CreditAttribution: SebCorbin commentedRe-rolled, adding a permission, and a history status.
Test should be bypassed by specifying type after name attribute on input element.
Comment #24
SebCorbin CreditAttribution: SebCorbin commentedMessed with the tests and forgot an empty()
Comment #25
Gábor HojtsyCode changes look good. I don't have time to test in the foreseeable future, so don't hold up on that :)
Comment #26
Pomliane CreditAttribution: Pomliane commentedWorks as expected but the string associated to the checkbox could probably be improved: something like "Author this suggestion and assign to [user]", maybe?
Comment #27
SebCorbin CreditAttribution: SebCorbin commentedTesting on 7.x-1.x